Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753560AbdCMWxN (ORCPT ); Mon, 13 Mar 2017 18:53:13 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:46702 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751687AbdCMWxH (ORCPT ); Mon, 13 Mar 2017 18:53:07 -0400 Date: Mon, 13 Mar 2017 23:53:02 +0100 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Jiri Pirko , Jason Cobham Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: set out of range ageing time Message-ID: <20170313225302.GD14183@lunn.ch> References: <20170313191932.12149-1-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170313191932.12149-1-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 585 Lines: 15 On Mon, Mar 13, 2017 at 03:19:32PM -0400, Vivien Didelot wrote: > The minimum and maximum value of the ATU Age Time varies depending on > the switch model. The current code returns -ERANGE for out-of-range > values, and makes switchdev commit phase fail with this stacktrace: Hi Vivien I took a look at other switch drivers. mlxsw return ERANGE in the prepare phase. rocker is not limited, since it is using software timers. It seems like the correct way to do this is via a prepare call, or add min/max fields to struct dsa_switch and let slave.c perform the check. Andrew