Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754197AbdCMXjj (ORCPT ); Mon, 13 Mar 2017 19:39:39 -0400 Received: from relmlor3.renesas.com ([210.160.252.173]:23679 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753336AbdCMXj3 (ORCPT ); Mon, 13 Mar 2017 19:39:29 -0400 X-IronPort-AV: E=Sophos;i="5.36,161,1486393200"; d="scan'208";a="236562187" From: Yoshihiro Shimoda To: Sergei Shtylyov , "kishon@ti.com" CC: "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" Subject: RE: [PATCH v2] phy: rcar-gen3-usb2: fix implementation for runtime PM Thread-Topic: [PATCH v2] phy: rcar-gen3-usb2: fix implementation for runtime PM Thread-Index: AQHSm94AiZEDEAVrcUG+ByZ32BoJaqGSqhWAgADDqxA= Date: Mon, 13 Mar 2017 23:39:20 +0000 Message-ID: References: <1489397969-26153-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <983f7c65-38f8-a04f-f809-ab6bbd8ac8f5@cogentembedded.com> In-Reply-To: <983f7c65-38f8-a04f-f809-ab6bbd8ac8f5@cogentembedded.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: cogentembedded.com; dkim=none (message not signed) header.d=none;cogentembedded.com; dmarc=none action=none header.from=renesas.com; x-originating-ip: [211.11.155.141] x-ms-office365-filtering-correlation-id: 095427af-e7b8-4fd5-be65-08d46a6a2c13 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:PS1PR06MB1690; x-microsoft-exchange-diagnostics: 1;PS1PR06MB1690;7:MmH5ginqKk+TSAu+F8tOUqf05tiaIZFQ+A/NyBJxYLCSowOt/3jxLLQ3uxYPe/TjnjAjKSjGD19h4qRIMG96hJe7v+OSTPKmosauk8otFVo0UmQA9ThB2hFCKPD1NVwteTX9n1hMDh27pic7YywMFgR6uwzfVPrDkR095akiPkgXZ6+T5BybkhDfjqPmsW87jNUYLwvuaomypkrOWLwNqgFcZs+n19Uwg1SbVn28jacJN+i2j8lcDFMnOEnnov0O/vWL5Ekrpbd0QMFDMfeeBC5VSwQ4jE9zMjmu3xcQdOkfEEJRYtGtXFIHXjgESf0gtld6Er4XKkonf+asr0adJA==;20:Cyii3h0QXk+7eSjAU1LnvzpsCeMFRnJ4UcJM+MQmSi1rH1tatoJbR6ACIugLLvFT4w678C9nCpyNyI4BCYmhQI/VhFOLgvnea8bLiK+5GJkZug2L0qnYztPS1Kf15YV0T/Q0mK6yoVjwgCcWY2m67dRSoH6oFdpeik0oS9b8+0o= x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123564025)(20161123560025)(20161123558025)(20161123562025)(6072148);SRVR:PS1PR06MB1690;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1690; x-forefront-prvs: 0245702D7B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(39840400002)(39450400003)(39410400002)(39850400002)(23433003)(377454003)(24454002)(43544003)(76176999)(6436002)(54356999)(77096006)(7736002)(229853002)(3660700001)(3280700002)(8936002)(6506006)(9686003)(54906002)(99286003)(122556002)(5660300001)(53546007)(81166006)(25786008)(8676002)(74316002)(50986999)(2906002)(189998001)(305945005)(53936002)(230783001)(2501003)(4326008)(6116002)(3846002)(106116001)(38730400002)(102836003)(2950100002)(33656002)(7696004)(66066001)(345774005)(2900100001)(86362001)(55016002)(6246003);DIR:OUT;SFP:1102;SCL:1;SRVR:PS1PR06MB1690;H:PS1PR06MB1692.apcprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2017 23:39:20.2151 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR06MB1690 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v2DNe6W3002161 Content-Length: 624 Lines: 19 Hi! > From: Sergei Shtylyov > Sent: Monday, March 13, 2017 8:57 PM > > On 03/13/2017 12:39 PM, Yoshihiro Shimoda wrote: > > > This patch fixes an issue that this driver doesn't take care of the runtime > > PM. This code assumed that devm_phy_create() called pm_runtime_enable(dev), > > but it misunderstood the dev_phy_create()'s specification. > > This driver should call its own pm_runtime_pm() before dev_phy_create(). > > You probably meant pm_runtime_enable()? Sorry for not noticing the 1st time... Yes, I meant pm_runtime_enable(). Thank you for the review again and again. Best regards, Yoshihiro Shimoda