Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753896AbdCNCIh convert rfc822-to-8bit (ORCPT ); Mon, 13 Mar 2017 22:08:37 -0400 Received: from mga06.intel.com ([134.134.136.31]:14397 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752044AbdCNCIg (ORCPT ); Mon, 13 Mar 2017 22:08:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,162,1486454400"; d="scan'208";a="59918822" From: "Brown, Aaron F" To: Philippe Reynes , "Kirsher, Jeffrey T" , "davem@davemloft.net" CC: "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [Intel-wired-lan] [PATCH] net: intel: ixgb: use new api ethtool_{get|set}_link_ksettings Thread-Topic: [Intel-wired-lan] [PATCH] net: intel: ixgb: use new api ethtool_{get|set}_link_ksettings Thread-Index: AQHSgAUsvpRxvhT7oUKfI8SDWw4hZqGTzvXA Date: Tue, 14 Mar 2017 02:08:33 +0000 Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B8C5B402C@ORSMSX101.amr.corp.intel.com> References: <1486336271-25336-1-git-send-email-tremyfr@gmail.com> In-Reply-To: <1486336271-25336-1-git-send-email-tremyfr@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1279 Lines: 24 > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On > Behalf Of Philippe Reynes > Sent: Sunday, February 5, 2017 3:11 PM > To: Kirsher, Jeffrey T ; davem@davemloft.net > Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux- > kernel@vger.kernel.org; Philippe Reynes > Subject: [Intel-wired-lan] [PATCH] net: intel: ixgb: use new api > ethtool_{get|set}_link_ksettings > > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes > --- > drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c | 39 ++++++++++++++--------- > - > 1 files changed, 23 insertions(+), 16 deletions(-) > Tested-by: Aaron Brown Well, compile / static tested by: I probably have an ixgb adapter somewhere as well as a PCI-X slot that might work for it, but am not sure I can find them or that they still function. If I stumble upon one I'll fire it up and run it through some paces, but the variant of this patch for other drivers seem good and I don't want to hold this patch up any longer.