Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753574AbdCNCuS (ORCPT ); Mon, 13 Mar 2017 22:50:18 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34219 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752282AbdCNCuR (ORCPT ); Mon, 13 Mar 2017 22:50:17 -0400 Date: Tue, 14 Mar 2017 10:50:12 +0800 From: Wei Yang To: Borislav Petkov Cc: Wei Yang , tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, tj@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo() Message-ID: <20170314025012.GA99092@WeideMacBook-Pro.local> Reply-To: Wei Yang References: <20170206153529.14614-1-richard.weiyang@gmail.com> <20170206153529.14614-2-richard.weiyang@gmail.com> <20170313133045.oq5agzhrz43pgw5o@pd.tnic> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TB36FDmn/VVEgNH/" Content-Disposition: inline In-Reply-To: <20170313133045.oq5agzhrz43pgw5o@pd.tnic> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2882 Lines: 91 --TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 13, 2017 at 02:30:46PM +0100, Borislav Petkov wrote: >On Mon, Feb 06, 2017 at 11:35:29PM +0800, Wei Yang wrote: >> numa_nodemask_from_meminfo() is called to set bit according to >> numa_meminfo. While the only two places for this call is used to set pro= per >> bit to a copy of numa_nodes_parsed from numa_meminfo. With current code >> path, those numa node information in numa_meminfo is a subset of >> numa_nodes_parsed. So it is not necessary to set the bits again. >>=20 >> The following is a code path analysis to prove the numa node information= in >> numa_meminfo is a subset of numa_nodes_parsed. >>=20 >> x86_numa_init() >> numa_init() >> Case 1 >> acpi_numa_init() >> acpi_parse_memory_affinity() >> numa_add_memblk() >> node_set(numa_nodes_parsed) >> acpi_parse_slit() >> numa_nodemask_from_meminfo() >>=20 >> Case 2 >> amd_numa_init() >> numa_add_memblk() >> node_set(numa_nodes_parsed) >>=20 >> Case 3 >> dummy_numa_init() >> node_set(numa_nodes_parsed) >> numa_add_memblk() >>=20 >> numa_register_memblks() >> numa_nodemask_from_meminfo() > >What about of_numa_parse_memory_nodes() ? > Hi, Borislav Glad to see your comment. Here is the only place who will invoke of_numa_parse_memory_nodes() arm64_numa_init() of_numa_init() of_numa_parse_memory_nodes() So this is an arm64 specific function. In this patch, these numa_nodemask_from_meminfo only affects x86. >--=20 >Regards/Gruss, > Boris. > >Good mailing practices for 400: avoid top-posting and trim the reply. --=20 Wei Yang Help you, Help me --TB36FDmn/VVEgNH/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIbBAEBCAAGBQJYx1pkAAoJEKcLNpZP5cTdkNUP+LU0mWuT9HjqMLdNSBgoWkCG qL9ehI7qJfZtz3iasZcdAqaIko724qXtTDkBdW1FSCbmPnrQrGGOl4jKnzf5b+Ow 3vbWTifZcnSHmgVCezJ4l+ZLAw6mnnGV7htqaIzOy3MyzhSIhcS1EfQS4Jjmj9yc pqkZfMu5nabyA8cLRopU9eOTE3FpBcVGQnJ38R0UJRFZteNSbTDni9BAlFtip1JH fHqiykIgDfTjo8f5USgaM2QFFjxxxqUwMl2qWJKicEz8aQsvGwOvnDrO1u8F2Exu BdNbO0I7pl5OwfPkxIxPDb7YPd8guX5OKHy3HubNcbuhRascX0GUP5LYVfGdzarL NKCUsnUCrY8ZxWZ1COdxVeWILHj/J3GuQ0T+zU6VlPVj+aqxQ38VIQC/X/PHrvun tSk3cBvkYRyAJ7/w92co6tSlJE/bkjk5ZorcvrkK2lJEAEmSG97MLrjoPbML5B5V ixQmarKtIKTVxhTZysEgJWiW38tXuzo15qKQeEoi+Mfmdvn0meUX6ngQJkD2L7qY UebfgqmwXjei4Ga4g9WsWmfy1XhvRcAPKcVHt1vxNwANmdzTvLLCgnT9eFlW4syT cStBexwsfiGLX0HA+AybGgYEOjOQZm845K0Z7oQ3PZzbQDm0fxJxU168DnEVjezl Al7zqJIWRLgObWzf0pw= =MmsW -----END PGP SIGNATURE----- --TB36FDmn/VVEgNH/--