Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750828AbdCNFhb (ORCPT ); Tue, 14 Mar 2017 01:37:31 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:11360 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbdCNFh3 (ORCPT ); Tue, 14 Mar 2017 01:37:29 -0400 X-IronPort-AV: E=Sophos;i="5.36,162,1486422000"; d="scan'208";a="264427622" Date: Tue, 14 Mar 2017 06:37:20 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: "zhichang.yuan" cc: catalin.marinas@arm.com, will.deacon@arm.com, robh+dt@kernel.org, frowand.list@gmail.com, bhelgaas@google.com, rafael@kernel.org, mark.rutland@arm.com, rjw@rjwysocki.net, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, lorenzo.pieralisi@arm.com, benh@kernel.crashing.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, minyard@acm.org, liviu.dudau@arm.com, zourongrong@gmail.com, john.garry@huawei.com, gabriele.paoloni@huawei.com, zhichang.yuan02@gmail.com, kantyzc@163.com, xuwei5@hisilicon.com, "zhichang.yuan" , kbuild-all@01.org Subject: Re: [PATCH V7 4/7] LPC: Support the device-tree LPC host on Hip06/Hip07 (fwd) Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2099 Lines: 48 Line 460 looks suspicious. Can tmprange be different than range but not be an ERR_PTR? If so, lpcdev->io_host will have an invalid value. julia ---------- Forwarded message ---------- Date: Tue, 14 Mar 2017 13:12:05 +0800 From: kbuild test robot To: kbuild@01.org Cc: Julia Lawall Subject: Re: [PATCH V7 4/7] LPC: Support the device-tree LPC host on Hip06/Hip07 Hi zhichang.yuan, [auto build test WARNING on linus/master] [also build test WARNING on v4.11-rc2 next-20170310] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/zhichang-yuan/LPC-legacy-ISA-I-O-support/20170314-114635 :::::: branch date: 85 minutes ago :::::: commit date: 85 minutes ago >> drivers/bus/hisi_lpc.c:465:19-24: ERROR: reference preceded by free on line 460 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 4e05ad6c3274fa75c903c7809ef0b51329a31ab2 vim +465 drivers/bus/hisi_lpc.c 4e05ad6c zhichang.yuan 2017-03-13 454 range->flags = IO_HOST_INDIRECT; 4e05ad6c zhichang.yuan 2017-03-13 455 range->size = LPC_BUS_IO_SIZE; 4e05ad6c zhichang.yuan 2017-03-13 456 range->hw_start = LPC_MIN_BUS_RANGE; 4e05ad6c zhichang.yuan 2017-03-13 457 4e05ad6c zhichang.yuan 2017-03-13 458 tmprange = register_libio_range(range); 4e05ad6c zhichang.yuan 2017-03-13 459 if (tmprange != range) { 4e05ad6c zhichang.yuan 2017-03-13 @460 kfree(range); 4e05ad6c zhichang.yuan 2017-03-13 461 if (IS_ERR(tmprange)) 4e05ad6c zhichang.yuan 2017-03-13 462 return -EFAULT; 4e05ad6c zhichang.yuan 2017-03-13 463 } 4e05ad6c zhichang.yuan 2017-03-13 464 4e05ad6c zhichang.yuan 2017-03-13 @465 lpcdev->io_host = range; 4e05ad6c zhichang.yuan 2017-03-13 466 4e05ad6c zhichang.yuan 2017-03-13 467 return 0; 4e05ad6c zhichang.yuan 2017-03-13 468 } --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation