Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750960AbdCNGW2 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 14 Mar 2017 02:22:28 -0400
Received: from mailgw02.mediatek.com ([210.61.82.184]:16593 "EHLO
        mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
        with ESMTP id S1750803AbdCNGW0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 14 Mar 2017 02:22:26 -0400
Message-ID: <1489472530.1870.21.camel@mtkswgap22>
Subject: Re: [PATCH net-next 2/4] net-next: dsa: add Mediatek tag RX/TX
 handler
From: Sean Wang <sean.wang@mediatek.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
CC: <andrew@lunn.ch>, <f.fainelli@gmail.com>, <matthias.bgg@gmail.com>,
        <robh+dt@kernel.org>, <mark.rutland@arm.com>,
        <devicetree@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-mediatek@lists.infradead.org>,
        <davem@davemloft.net>, <Landen.Chao@mediatek.com>,
        <keyhaede@gmail.com>, <objelf@gmail.com>
Date: Tue, 14 Mar 2017 14:22:10 +0800
In-Reply-To: <87innd6rk2.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
References: <1489421488-300-1-git-send-email-sean.wang@mediatek.com>
         <1489421488-300-3-git-send-email-sean.wang@mediatek.com>
         <87innd6rk2.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 412
Lines: 21

On Mon, 2017-03-13 at 12:59 -0400, Vivien Didelot wrote:
> Hi Sean,
> 
> sean.wang@mediatek.com writes:
> 
> > +	mtk_tag[1] = (1 << p->port) & MTK_HDR_XMIT_DP_BIT_MASK;
> 
> This won't apply, the port index in now stored in p->dp->index.
> 
> Thanks,
> 
>         Vivien


Hi Vivien,

It seems that I need to upgrade to newer kernel to verify this

thanks for your review , I'll fix this in the next one.

	Sean