Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750912AbdCNIlu (ORCPT ); Tue, 14 Mar 2017 04:41:50 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34514 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbdCNIlr (ORCPT ); Tue, 14 Mar 2017 04:41:47 -0400 Date: Tue, 14 Mar 2017 09:41:42 +0100 From: Daniel Vetter To: Sean Paul Cc: Emil Velikov , Arnd Bergmann , linux-arm-msm , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , stable , freedreno@lists.freedesktop.org Subject: Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs Message-ID: <20170314084142.hiy2yzrbeu3wqr2k@phenom.ffwll.local> Mail-Followup-To: Sean Paul , Emil Velikov , Arnd Bergmann , linux-arm-msm , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , stable , freedreno@lists.freedesktop.org References: <20170313164421.1090339-1-arnd@arndb.de> <20170313194848.GW20329@art_vandelay> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170313194848.GW20329@art_vandelay> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1492 Lines: 34 On Mon, Mar 13, 2017 at 03:48:48PM -0400, Sean Paul wrote: > On Mon, Mar 13, 2017 at 06:09:17PM +0000, Emil Velikov wrote: > > On 13 March 2017 at 17:00, Rob Clark wrote: > > > On Mon, Mar 13, 2017 at 12:43 PM, Arnd Bergmann wrote: > > >> The newly added a5xx support fails to build when debugfs is diabled: > > >> > > >> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:4: error: 'struct msm_gpu_funcs' has no member named 'show' > > >> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:11: error: 'a5xx_show' undeclared here (not in a function); did you mean 'a5xx_irq'? > > >> > > >> This adds a missing #ifdef. > > >> > > >> Fixes: b5f103ab98c7 ("drm/msm: gpu: Add A5XX target support") > > >> Cc: stable@vger.kernel.org > > >> Signed-off-by: Arnd Bergmann > > > > > > I thought I had picked this one up already, but I guess my brain was > > > playing tricks on me.. I've pushed this to msm-next for now and will > > > cherry-pick this over to a -fixes branch when I send fixes for 4.11.. > > > > > Sean sent a similar patch last week. I think he picked it (alongside > > others) in drm-misc-fixes. > > Haven't checked though ;-) > > Indeed [1]. I pushed it to drm-misc-fixes, but I don't see it there any longer. > > At any rate, I'm glad we got the fix merged somewhere. Bad me has force-rebased -fixes once because I screwed up something. Sorry about that :( -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch