Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750964AbdCNJAU (ORCPT ); Tue, 14 Mar 2017 05:00:20 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:36940 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbdCNJAR (ORCPT ); Tue, 14 Mar 2017 05:00:17 -0400 Subject: Re: [PATCH 2/2] ata: ahci: add support for DaVinci DM816 SATA controller To: Sergei Shtylyov , Bartosz Golaszewski , Tejun Heo , Rob Herring , Mark Rutland , Michael Turquette , Kevin Hilman , Patrick Titiano References: <1489422982-3461-1-git-send-email-bgolaszewski@baylibre.com> <1489422982-3461-3-git-send-email-bgolaszewski@baylibre.com> Cc: linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Neil Armstrong Organization: Baylibre Message-ID: <7ab4b440-f9d0-22fa-f463-f4c5542e21e7@baylibre.com> Date: Tue, 14 Mar 2017 10:00:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 49 On 03/14/2017 09:57 AM, Sergei Shtylyov wrote: > Hello! > > On 3/13/2017 7:36 PM, Bartosz Golaszewski wrote: > >> This SATA controller is quite similar to the one present on the DA850 >> SoC, but the PHY configuration is different and it supports two HBA >> ports. >> >> The IP suffers from the same PMP issue the DA850 does - if we enable >> PMP but don't use it - softreset fails. Appropriate workaround was >> implemented in this driver as well. >> >> Signed-off-by: Bartosz Golaszewski >> --- >> drivers/ata/Kconfig | 9 +++ >> drivers/ata/Makefile | 1 + >> drivers/ata/ahci_dm816.c | 200 +++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 210 insertions(+) >> create mode 100644 drivers/ata/ahci_dm816.c >> >> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig >> index 70b57d2..7f59a7a 100644 >> --- a/drivers/ata/Kconfig >> +++ b/drivers/ata/Kconfig >> @@ -118,6 +118,15 @@ config AHCI_DA850 >> >> If unsure, say N. >> >> +config AHCI_DM816 >> + tristate "DaVinci DM816 AHCI SATA support" > > Is it really DaVinci? > >> + depends on ARCH_OMAP2PLUS > > Especially if it depends on OMAP... Hi Sergei, Yes it's a DaVinci family SoC, but shares a lot of IPs with the OMAP family. Neil > > [...] > > MBR, Sergei >