Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750992AbdCNJDA (ORCPT ); Tue, 14 Mar 2017 05:03:00 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55283 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbdCNJC6 (ORCPT ); Tue, 14 Mar 2017 05:02:58 -0400 Subject: Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src To: Peter Zijlstra References: <1488796993-25495-1-git-send-email-maddy@linux.vnet.ibm.com> <1488796993-25495-2-git-send-email-maddy@linux.vnet.ibm.com> <20170306112228.GZ6515@twins.programming.kicks-ass.net> <2fc7e466-1675-ef27-b820-ef33ed0be7da@linux.vnet.ibm.com> <20170307102359.GE6515@twins.programming.kicks-ass.net> <78c1b95d-2e82-f998-74ba-ebb1fdf5bb45@linux.vnet.ibm.com> <20170313125041.GB3328@twins.programming.kicks-ass.net> Cc: mpe@ellerman.id.au, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sukadev Bhattiprolu , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Wang Nan , Alexei Starovoitov , Stephane Eranian From: Madhavan Srinivasan Date: Tue, 14 Mar 2017 14:31:51 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170313125041.GB3328@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17031409-0052-0000-0000-00000222A792 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17031409-0053-0000-0000-000007F68CC2 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-14_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703140073 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 633 Lines: 17 On Monday 13 March 2017 06:20 PM, Peter Zijlstra wrote: > On Mon, Mar 13, 2017 at 04:45:51PM +0530, Madhavan Srinivasan wrote: >>> - should you not have fixed this in the tool only? This patch >>> effectively breaks ABI on big-endian architectures. >> IIUC, we are the first BE user for this feature >> (Kindly correct me if I am wrong), so technically we >> are not breaking ABI here :) . But let me also look at >> the dynamic conversion part. > Huh? PPC hasn't yet implemented this? Then why are you fixing it? yes, PPC hasn't implemented this (until now). And did not understand "Then why are you fixing it?" Maddy >