Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750861AbdCNLcr (ORCPT ); Tue, 14 Mar 2017 07:32:47 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:4319 "EHLO dggrg01-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750744AbdCNLcq (ORCPT ); Tue, 14 Mar 2017 07:32:46 -0400 Subject: Re: [PATCH v2] f2fs: restrict write IO alignment condition To: Jaegeuk Kim References: <20170313130216.108395-1-yuchao0@huawei.com> <20170313200544.GE41055@jaegeuk.local> CC: , , From: Chao Yu Message-ID: <07e43857-1387-eb9b-478d-57d2f14d81e4@huawei.com> Date: Tue, 14 Mar 2017 19:32:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170313200544.GE41055@jaegeuk.local> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.58C7D4C3.0027,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 5bc795ce3d3db00aac4661064787b628 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1784 Lines: 66 On 2017/3/14 4:05, Jaegeuk Kim wrote: > On 03/13, Chao Yu wrote: >> We should only align start offset of bio with defined IO_SIZE for below >> conditions: >> a. mode=lfs mount option >> b. write IOs >> c. Out-place-update >> d. non-meta pages >> >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/data.c | 10 +++++++--- >> 1 file changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >> index 1375fef11146..53fe79c70406 100644 >> --- a/fs/f2fs/data.c >> +++ b/fs/f2fs/data.c >> @@ -190,6 +190,9 @@ static inline void __submit_bio(struct f2fs_sb_info *sbi, >> current->plug && (type == DATA || type == NODE)) >> blk_finish_plug(current->plug); >> >> + if (!test_opt(sbi, LFS)) >> + goto submit_io; > > The parse_options in fill_super checks this. You're right, I missed that one... > >> + >> if (type != DATA && type != NODE) >> goto submit_io; >> >> @@ -395,11 +398,12 @@ int f2fs_submit_page_mbio(struct f2fs_io_info *fio) >> __submit_merged_bio(io); >> alloc_new: >> if (io->bio == NULL) { >> - if ((fio->type == DATA || fio->type == NODE) && >> + if (test_opt(sbi, LFS) && >> + !is_read && (fio->type == DATA || fio->type == NODE) && > > The missing case is !is_read, here? > But, actually, DATA and NODE don't issue any read commands at all. Correct, let me add BUG_ON here. :) Thanks, > > Thanks, > >> fio->new_blkaddr & F2FS_IO_SIZE_MASK(sbi)) { >> err = -EAGAIN; >> - if (!is_read) >> - dec_page_count(sbi, WB_DATA_TYPE(bio_page)); >> + f2fs_bug_on(sbi, fio->new_blkaddr == fio->old_blkaddr); >> + dec_page_count(sbi, WB_DATA_TYPE(bio_page)); >> goto out_fail; >> } >> io->bio = __bio_alloc(sbi, fio->new_blkaddr, >> -- >> 2.8.2.295.g3f1c1d0 > > . >