Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751108AbdCNLqE (ORCPT ); Tue, 14 Mar 2017 07:46:04 -0400 Received: from ozlabs.org ([103.22.144.67]:37029 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751072AbdCNLqC (ORCPT ); Tue, 14 Mar 2017 07:46:02 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 46f401c4297a2232a037ad8801b6c83c90414cf7 In-Reply-To: <20170310023351.973-1-Larry.Finger@lwfinger.net> To: Larry Finger , Linus Torvalds From: Michael Ellerman Cc: "regressions @ leemhuis . info" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Larry Finger Subject: Re: powerpc: Fix crash introduced with commit 5657933dbb6e Message-Id: <3vjCc82PtWz9s2G@ozlabs.org> Date: Tue, 14 Mar 2017 22:46:00 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 24 On Fri, 2017-03-10 at 02:33:51 UTC, Larry Finger wrote: > Code inserted during the code merged between kernels 4.10 and 4.11-rc1 > caused an early panic quickly followed by a complete shutdown for > PowerPC. The traceback was not displayed long enough to read or > photograph, thus it is not reproduced here. > > The problem was bisected to commit 5657933dbb6e ("treewide: Move dma_ops > from struct dev_archdata into struct device"). The problem was a missing > copy of critical information from struct dev_archdata into struct device, > leading to the dereference of a null pointer. > > This fix was suggested by Benjamin Herrenschmidt. > > Fixes: commit 5657933dbb6e ("treewide: Move dma_ops from struct dev_archdata into struct device") > Signed-off-by: Larry Finger > Cc: linuxppc-dev@lists.ozlabs.org > Cc: Benjamin Herrenschmidt > Cc: regressions@leemhuis.info Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/46f401c4297a2232a037ad8801b6c8 cheers