Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750931AbdCNMFq (ORCPT ); Tue, 14 Mar 2017 08:05:46 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:47268 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750744AbdCNMFn (ORCPT ); Tue, 14 Mar 2017 08:05:43 -0400 Date: Tue, 14 Mar 2017 13:05:39 +0100 From: Andrew Lunn To: Matthias May Cc: Florian Fainelli , Vivien Didelot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Jason Cobham Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time Message-ID: <20170314120539.GT15842@lunn.ch> References: <20170313192043.12478-1-vivien.didelot@savoirfairelinux.com> <20170313223932.GC14183@lunn.ch> <20170313225845.GE14183@lunn.ch> <535be006-e384-aca3-ee8b-4ed36b66b97a@neratec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <535be006-e384-aca3-ee8b-4ed36b66b97a@neratec.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 702 Lines: 17 > Hi > The never ever seeing R/W failure on MDIO bus is not exactly accurate. > We had with art (atheros calibration tool) the problem that interrupts > were being disabled which lead to MDIO operations running into > timout/failing. Yes, i've seen similar with power management bugs for the MDIO driver. But you get a cascade of failures, lots of warnings and error prints, it is clear something bad has happened, and the switch is in an inconsistent state. So having one more debug print which is also inconsistent does no really harm. Anyway, this whole conversation has taken more effort than just making this simple change to remove a few lines of code. So lets drop it and move on. Andrew