Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752659AbdCNNqy (ORCPT ); Tue, 14 Mar 2017 09:46:54 -0400 Received: from foss.arm.com ([217.140.101.70]:33572 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbdCNNpx (ORCPT ); Tue, 14 Mar 2017 09:45:53 -0400 Subject: Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo To: Stefan Kristiansson References: <3e06a16339303016b2c57b350a15afeaa7ba7813.1487702890.git.shorne@gmail.com> <20170314131119.GA10854@chokladfabriken.org> Cc: Sudeep Holla , Stafford Horne , Jonas Bonn , linux@roeck-us.net, openrisc@lists.librecores.org, open list , Olof Kindgren , Rob Herring From: Sudeep Holla Organization: ARM Message-ID: <12dd3b5a-08fc-b397-b298-490f72610a5f@arm.com> Date: Tue, 14 Mar 2017 13:45:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170314131119.GA10854@chokladfabriken.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 954 Lines: 29 On 14/03/17 13:11, Stefan Kristiansson wrote: > On Tue, Mar 14, 2017 at 12:08:33PM +0000, Sudeep Holla wrote: >> On Tue, Feb 21, 2017 at 7:11 PM, Stafford Horne wrote: >>> From: Stefan Kristiansson >>> >>> Motivation for this is to be able to print the way information >>> properly in print_cpuinfo(), instead of hardcoding it to one. >>> >> >> Any particular reason not to use generic cacheinfo sysfs infrastructure ? >> > > No reason as far as I can see, the creation of this patch predates the > generic cacheinfo sysfs infrastructure. > > The patch itself doesn't add cache information to cpuinfo though, > only corrects a bug in the information that is already there. > > We should look into exposing the info in the generic cache info sysfs > and potentially removing the information from cpuinfo. > Ah OK, sorry I mistook it as a new addition rather than bug fox. -- Regards, Sudeep