Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751799AbdCNNy4 (ORCPT ); Tue, 14 Mar 2017 09:54:56 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34126 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbdCNNxt (ORCPT ); Tue, 14 Mar 2017 09:53:49 -0400 Message-ID: <1489499621.2338.6.camel@gmail.com> Subject: Re: [PATCH v6 1/3] drm_fourcc: Add new P010, P016 video format From: Ander Conselvan De Oliveira To: Ayaka , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , "Taylor, Clinton A" Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mchehab@kernel.org, linux-media@vger.kernel.org Date: Tue, 14 Mar 2017 15:53:41 +0200 In-Reply-To: References: <1488708033-5691-1-git-send-email-ayaka@soulik.info> <1488708033-5691-2-git-send-email-ayaka@soulik.info> <20170306130609.GT31595@intel.com> <20170306183434.GV31595@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.4 (3.22.4-2.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4934 Lines: 118 On Tue, 2017-03-07 at 04:27 +0800, Ayaka wrote: > > 從我的 iPad 傳送 > > > Ville Syrjälä 於 2017年3月7日 上午2:34 寫道： > > > > > On Tue, Mar 07, 2017 at 01:58:23AM +0800, Ayaka wrote: > > > > > > > > > 從我的 iPad 傳送 > > > > > > > > Ville Syrjälä 於 2017年3月6日 下午9:06 寫道： > > > > > > > > > > On Sun, Mar 05, 2017 at 06:00:31PM +0800, Randy Li wrote: > > > > > P010 is a planar 4:2:0 YUV with interleaved UV plane, 10 bits > > > > > per channel video format. > > > > > > > > > > P016 is a planar 4:2:0 YUV with interleaved UV plane, 16 bits > > > > > per channel video format. > > > > > > > > > > V3: Added P012 and fixed cpp for P010 > > > > > V4: format definition refined per review > > > > > V5: Format comment block for each new pixel format > > > > > V6: reversed Cb/Cr order in comments > > > > > v7: reversed Cb/Cr order in comments of header files, remove > > > > > the wrong part of commit message. > > > > > > > > What? Why? You just undid what Clint did in v6. > > > > > > He missed a file also keeping the wrong description of rockchip. > > > > I don't follow. Who missed what exactly? > > What he sent is v5, I increase the order number twice in the message, it confuse me as well. > I think Clint forgot the include/uapi/drm/drm_fourcc.h . Clint did send a v6, and that updates "include/uapi/drm/drm_fourcc.h": https://patchwork.freedesktop.org/patch/141342/ Ander > > > > > > > > > > > > > > > > > > Cc: Daniel Stone > > > > > Cc: Ville Syrjälä > > > > > > > > > > Signed-off-by: Randy Li > > > > > Signed-off-by: Clint Taylor > > > > > --- > > > > > drivers/gpu/drm/drm_fourcc.c | 3 +++ > > > > > include/uapi/drm/drm_fourcc.h | 21 +++++++++++++++++++++ > > > > > 2 files changed, 24 insertions(+) > > > > > > > > > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > > > > > index 90d2cc8..3e0fd58 100644 > > > > > --- a/drivers/gpu/drm/drm_fourcc.c > > > > > +++ b/drivers/gpu/drm/drm_fourcc.c > > > > > @@ -165,6 +165,9 @@ const struct drm_format_info *__drm_format_info(u32 format) > > > > > { .format = DRM_FORMAT_UYVY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 }, > > > > > { .format = DRM_FORMAT_VYUY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 }, > > > > > { .format = DRM_FORMAT_AYUV, .depth = 0, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1 }, > > > > > + { .format = DRM_FORMAT_P010, .depth = 0, .num_planes = 2, .cpp = { 2, 4, 0 }, .hsub = 2, .vsub = 2 }, > > > > > + { .format = DRM_FORMAT_P012, .depth = 0, .num_planes = 2, .cpp = { 2, 4, 0 }, .hsub = 2, .vsub = 2 }, > > > > > + { .format = DRM_FORMAT_P016, .depth = 0, .num_planes = 2, .cpp = { 2, 4, 0 }, .hsub = 2, .vsub = 2 }, > > > > > }; > > > > > > > > > > unsigned int i; > > > > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > > > > > index ef20abb..306f979 100644 > > > > > --- a/include/uapi/drm/drm_fourcc.h > > > > > +++ b/include/uapi/drm/drm_fourcc.h > > > > > @@ -128,6 +128,27 @@ extern "C" { > > > > > #define DRM_FORMAT_NV42 fourcc_code('N', 'V', '4', '2') /* non-subsampled Cb:Cr plane */ > > > > > > > > > > /* > > > > > + * 2 plane YCbCr MSB aligned > > > > > + * index 0 = Y plane, [15:0] Y:x [10:6] little endian > > > > > + * index 1 = Cb:Cr plane, [31:0] Cb:x:Cr:x [10:6:10:6] little endian > > > > > + */ > > > > > +#define DRM_FORMAT_P010 fourcc_code('P', '0', '1', '0') /* 2x2 subsampled Cb:Cr plane 10 bits per channel */ > > > > > + > > > > > +/* > > > > > + * 2 plane YCbCr MSB aligned > > > > > + * index 0 = Y plane, [15:0] Y:x [12:4] little endian > > > > > + * index 1 = Cb:Cr plane, [31:0] Cb:x:Cr:x [12:4:12:4] little endian > > > > > + */ > > > > > +#define DRM_FORMAT_P012 fourcc_code('P', '0', '1', '2') /* 2x2 subsampled Cb:Cr plane 12 bits per channel */ > > > > > + > > > > > +/* > > > > > + * 2 plane YCbCr MSB aligned > > > > > + * index 0 = Y plane, [15:0] Y little endian > > > > > + * index 1 = Cb:Cr plane, [31:0] Cb:Cr [16:16] little endian > > > > > + */ > > > > > +#define DRM_FORMAT_P016 fourcc_code('P', '0', '1', '6') /* 2x2 subsampled Cb:Cr plane 16 bits per channel */ > > > > > + > > > > > +/* > > > > > * 3 plane YCbCr > > > > > * index 0: Y plane, [7:0] Y > > > > > * index 1: Cb plane, [7:0] Cb > > > > > -- > > > > > 2.7.4 > > > > > > > > -- > > > > Ville Syrjälä > > > > Intel OTC > > > > -- > > Ville Syrjälä > > Intel OTC > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel