Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751955AbdCNOJq (ORCPT <rfc822;w@1wt.eu>);
        Tue, 14 Mar 2017 10:09:46 -0400
Received: from mail-pg0-f67.google.com ([74.125.83.67]:34306 "EHLO
        mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751645AbdCNOJo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 14 Mar 2017 10:09:44 -0400
Date: Tue, 14 Mar 2017 23:09:40 +0900
From: Stafford Horne <shorne@gmail.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
        Jonas Bonn <jonas@southpole.se>, linux@roeck-us.net,
        openrisc@lists.librecores.org,
        open list <linux-kernel@vger.kernel.org>,
        Olof Kindgren <olof.kindgren@gmail.com>, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo
Message-ID: <20170314140940.GD2418@lianli.shorne-pla.net>
References: <cover.1487702890.git.shorne@gmail.com>
 <3e06a16339303016b2c57b350a15afeaa7ba7813.1487702890.git.shorne@gmail.com>
 <CAPKp9uadcs_N82DNbhT+FoizVDBA6xCxee9fGGkER3_3+q9rvA@mail.gmail.com>
 <20170314131119.GA10854@chokladfabriken.org>
 <12dd3b5a-08fc-b397-b298-490f72610a5f@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <12dd3b5a-08fc-b397-b298-490f72610a5f@arm.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1321
Lines: 37

On Tue, Mar 14, 2017 at 01:45:24PM +0000, Sudeep Holla wrote:
> 
> 
> On 14/03/17 13:11, Stefan Kristiansson wrote:
> > On Tue, Mar 14, 2017 at 12:08:33PM +0000, Sudeep Holla wrote:
> >> On Tue, Feb 21, 2017 at 7:11 PM, Stafford Horne <shorne@gmail.com> wrote:
> >>> From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> >>>
> >>> Motivation for this is to be able to print the way information
> >>> properly in print_cpuinfo(), instead of hardcoding it to one.
> >>>
> >>
> >> Any particular reason not to use generic cacheinfo sysfs infrastructure ?
> >>
> > 
> > No reason as far as I can see, the creation of this patch predates the
> > generic cacheinfo sysfs infrastructure.
> > 
> > The patch itself doesn't add cache information to cpuinfo though,
> > only corrects a bug in the information that is already there.
> > 
> > We should look into exposing the info in the generic cache info sysfs
> > and potentially removing the information from cpuinfo.
> > 
> 
> Ah OK, sorry I mistook it as a new addition rather than bug fox.

Hello,

The comment is appreciated I didnt know about the generic cacheinfo
intrstructure to be honest.  The simplifications it brings look good, I
will put this on my todo list.

If you want to have a go at patching it in for openrisc it would be
appreciated. :)

-Stafford