Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751989AbdCNONo (ORCPT ); Tue, 14 Mar 2017 10:13:44 -0400 Received: from mail-wr0-f171.google.com ([209.85.128.171]:36203 "EHLO mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbdCNOMM (ORCPT ); Tue, 14 Mar 2017 10:12:12 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH RFC 00/14] Add the BFQ I/O Scheduler to blk-mq From: Paolo Valente In-Reply-To: <1D08B61A9CF0974AA09887BE32D889DA0DA827@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> Date: Tue, 14 Mar 2017 15:12:06 +0100 Cc: Jens Axboe , Tejun Heo , Fabio Checconi , Arianna Avanzini , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ulf.hansson@linaro.org" , "linus.walleij@linaro.org" , "broonie@kernel.org" Message-Id: <3498DE72-65D0-4D1A-9CA6-9176137AF6CE@linaro.org> References: <20170304160131.57366-1-paolo.valente@linaro.org> <1D08B61A9CF0974AA09887BE32D889DA0DA827@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> To: Bart Van Assche X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2EEDl78002051 Content-Length: 1140 Lines: 40 > Il giorno 07 mar 2017, alle ore 01:22, Bart Van Assche ha scritto: > > On 03/04/2017 08:01 AM, Paolo Valente wrote: >> Some patch generates WARNINGS with checkpatch.pl, but these WARNINGS >> seem to be either unavoidable for the involved pieces of code (which >> the patch just extends), or false positives. > > The code in this series looks reasonably clean from a code style point > of view, Great, thanks! > but please address all checkpatch warnings that can be > addressed easily. A few examples of such checkpatch warnings: > > ERROR: "foo * bar" should be "foo *bar" > The offending line is: *(__PTR) = (u64)__data * NSEC_PER_USEC; so this seems a false positive. > WARNING: Symbolic permissions 'S_IRUGO|S_IWUSR' are not preferred. > Consider using octal permissions '0644'. > I have used symbolic permissions because I find them much easier to remember and decode than numeric constants, and because it is done so in cfq-iosched.c, deadline-iosched.c and now mq-deadline.c. But, since you share this checkpatch complain, I will switch to constants. Thanks, Paolo > Thanks, > > Bart.