Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752753AbdCNOzm (ORCPT ); Tue, 14 Mar 2017 10:55:42 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:36983 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752424AbdCNOzj (ORCPT ); Tue, 14 Mar 2017 10:55:39 -0400 Date: Tue, 14 Mar 2017 15:55:27 +0100 From: Gary Bisson To: Linus Walleij Cc: Mika =?iso-8859-1?Q?Penttil=E4?= , ext Tony Lindgren , Stefan Agner , Shawn Guo , LKML , "linux-gpio@vger.kernel.org" Subject: Re: [PATCH] fix pinctrl setup for i.IMX6 Message-ID: <20170314145527.q53qh7yzm2x4zksf@t450s.lan> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1292 Lines: 36 Hi Linus, On Tue, Mar 14, 2017 at 03:47:58PM +0100, Linus Walleij wrote: > On Tue, Feb 28, 2017 at 7:00 AM, Mika Penttil? > wrote: > > > Recent pulls for mainline pre 4.11 introduced pinctrl setup changes and moved pinctrl-imx to > > use generic helpers. > > > > Net effect was that hog group could not be resolved. I made it work for myself > > with a two stage setup with create and start separated, and dt probe in between them. > > > > > > Signed-off-by: Mika Penttil? > > Sorry for including the whole mail body, some people may have missed the > mail. Notably the i.MX maintainers. > > Your patch reminds me of the pinctrl_register() vs pinctrl_register_and_init() > introduced by Tony Lindgren, can you look into this in commit > 950b0d91dc108f54bccca5a2f75bb46f2df63d29 > "pinctrl: core: Fix regression caused by delayed work for hogs"? > > Does switching pinctrl_register_and_init() back to pinctrl_register() > solve your problem? > > Gary: have you seen any problem like this? Yes, Mika brought it up as soon as the first 4.11-rc appeared and indeed this issue can be reproduced on any i.MX6 platform. Then Tony offered a patch but you haven't replied to him yet: https://lkml.org/lkml/2017/2/28/140 Regards, Gary