Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752956AbdCNO5C (ORCPT ); Tue, 14 Mar 2017 10:57:02 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34056 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752906AbdCNO47 (ORCPT ); Tue, 14 Mar 2017 10:56:59 -0400 From: Stafford Horne To: linux-kernel@vger.kernel.org Cc: openrisc@lists.librecores.org, Stafford Horne , Jonas Bonn , Stefan Kristiansson , Al Viro , Guenter Roeck Subject: [PATCH 2/3] openrisc: fix issue handling 8 byte get_user calls Date: Tue, 14 Mar 2017 23:56:27 +0900 Message-Id: <0919e155a0de5d4e6fd8a70c56b8ee44eac37dd2.1489502779.git.shorne@gmail.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 27 Was getting the following error with allmodconfig: ERROR: "__get_user_bad" [lib/test_user_copy.ko] undefined! This was simply a missing break statement, causing an unwanted fall through. Signed-off-by: Stafford Horne --- arch/openrisc/include/asm/uaccess.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/openrisc/include/asm/uaccess.h b/arch/openrisc/include/asm/uaccess.h index 140faa1..1311e6b 100644 --- a/arch/openrisc/include/asm/uaccess.h +++ b/arch/openrisc/include/asm/uaccess.h @@ -211,7 +211,7 @@ do { \ case 1: __get_user_asm(x, ptr, retval, "l.lbz"); break; \ case 2: __get_user_asm(x, ptr, retval, "l.lhz"); break; \ case 4: __get_user_asm(x, ptr, retval, "l.lwz"); break; \ - case 8: __get_user_asm2(x, ptr, retval); \ + case 8: __get_user_asm2(x, ptr, retval); break; \ default: (x) = __get_user_bad(); \ } \ } while (0) -- 2.9.3