Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752988AbdCNO5F (ORCPT ); Tue, 14 Mar 2017 10:57:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60794 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752955AbdCNO5C (ORCPT ); Tue, 14 Mar 2017 10:57:02 -0400 Date: Tue, 14 Mar 2017 15:56:56 +0100 From: Jiri Benc To: Matthias Schiffer Cc: davem@davemloft.net, hannes@stressinduktion.org, pshelar@ovn.org, aduyck@mirantis.com, roopa@cumulusnetworks.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/3] vxlan: fix snooping for link-local IPv6 addresses Message-ID: <20170314155656.1446a358@griffin> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 14 Mar 2017 14:57:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 515 Lines: 16 On Fri, 10 Mar 2017 23:39:43 +0100, Matthias Schiffer wrote: > --- a/drivers/net/vxlan.c > +++ b/drivers/net/vxlan.c > @@ -941,16 +941,24 @@ static int vxlan_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb, > */ > static bool vxlan_snoop(struct net_device *dev, > union vxlan_addr *src_ip, const u8 *src_mac, > - __be32 vni) > + __u32 src_ifindex, __be32 vni) Just "u32", please. No double underscores for u32 inside the kernel-only code. (Also in other places in this patch.) Thanks, Jiri