Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752646AbdCNPZy (ORCPT ); Tue, 14 Mar 2017 11:25:54 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:36774 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbdCNPZd (ORCPT ); Tue, 14 Mar 2017 11:25:33 -0400 MIME-Version: 1.0 In-Reply-To: <05e67e380f8a29ce479a180a3bbd145f30236b16.1489502779.git.shorne@gmail.com> References: <05e67e380f8a29ce479a180a3bbd145f30236b16.1489502779.git.shorne@gmail.com> From: Geert Uytterhoeven Date: Tue, 14 Mar 2017 16:25:30 +0100 X-Google-Sender-Auth: dTbglksw5YZdI-yDNqzcp2icgZ0 Message-ID: Subject: Re: [OpenRISC] [PATCH 3/3] openrisc: Export symbols needed by modules To: Stafford Horne Cc: "linux-kernel@vger.kernel.org" , Jonas Bonn , Christian Svensson , openrisc@lists.librecores.org, Ingo Molnar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1407 Lines: 40 Hi Stafford, On Tue, Mar 14, 2017 at 3:56 PM, Stafford Horne wrote: > This was detected by allmodconfig, errors reported: > > ERROR: "empty_zero_page" [net/ceph/libceph.ko] undefined! > ERROR: "__ucmpdi2" [lib/842/842_decompress.ko] undefined! > ERROR: "empty_zero_page" [fs/nfs/objlayout/objlayoutdriver.ko] undefined! > ERROR: "empty_zero_page" [fs/exofs/exofs.ko] undefined! > ERROR: "empty_zero_page" [fs/crypto/fscrypto.ko] undefined! > ERROR: "__ucmpdi2" [fs/btrfs/btrfs.ko] undefined! > ERROR: "pm_power_off" [drivers/regulator/act8865-regulator.ko] undefined! > > Signed-off-by: Stafford Horne > --- a/arch/openrisc/kernel/or32_ksyms.c > +++ b/arch/openrisc/kernel/or32_ksyms.c > @@ -42,6 +42,11 @@ DECLARE_EXPORT(__muldi3); > DECLARE_EXPORT(__ashrdi3); > DECLARE_EXPORT(__ashldi3); > DECLARE_EXPORT(__lshrdi3); > +DECLARE_EXPORT(__ucmpdi2); > + > +extern unsigned long empty_zero_page[2048]; Can't you #include instead of adding a forward declaration? > +EXPORT_SYMBOL(empty_zero_page); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds