Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751330AbdCNNMl (ORCPT ); Tue, 14 Mar 2017 09:12:41 -0400 Received: from smtp-68.nebula.fi ([83.145.220.68]:43575 "EHLO smtp.nebula.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750846AbdCNNLa (ORCPT ); Tue, 14 Mar 2017 09:11:30 -0400 Date: Tue, 14 Mar 2017 15:11:23 +0200 From: Stefan Kristiansson To: Sudeep Holla Cc: Stafford Horne , Jonas Bonn , linux@roeck-us.net, openrisc@lists.librecores.org, open list , Olof Kindgren , Rob Herring Subject: Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo Message-ID: <20170314131119.GA10854@chokladfabriken.org> References: <3e06a16339303016b2c57b350a15afeaa7ba7813.1487702890.git.shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 802 Lines: 21 On Tue, Mar 14, 2017 at 12:08:33PM +0000, Sudeep Holla wrote: > On Tue, Feb 21, 2017 at 7:11 PM, Stafford Horne wrote: > > From: Stefan Kristiansson > > > > Motivation for this is to be able to print the way information > > properly in print_cpuinfo(), instead of hardcoding it to one. > > > > Any particular reason not to use generic cacheinfo sysfs infrastructure ? > No reason as far as I can see, the creation of this patch predates the generic cacheinfo sysfs infrastructure. The patch itself doesn't add cache information to cpuinfo though, only corrects a bug in the information that is already there. We should look into exposing the info in the generic cache info sysfs and potentially removing the information from cpuinfo. Stefan