Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751170AbdCNQKC (ORCPT ); Tue, 14 Mar 2017 12:10:02 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:36678 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752596AbdCNQIo (ORCPT ); Tue, 14 Mar 2017 12:08:44 -0400 Subject: Re: [PATCH v7 2/2] backlight arcxcnn add support for ArcticSand devices To: Brian Dodge , Olimpiu Dejeu , robh@kernel.org References: <1489429323-6103-1-git-send-email-olimpiu@arcticsand.com> <61f6e116-6190-72f3-ca89-54c9a94a6ac2@arcticsand.com> Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org, jingoohan1@gmail.com, joe@perches.com, medasaro@arcticsand.com From: Daniel Thompson Message-ID: <44a210ee-f0c4-3933-c696-09446028d249@linaro.org> Date: Tue, 14 Mar 2017 16:08:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <61f6e116-6190-72f3-ca89-54c9a94a6ac2@arcticsand.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1705 Lines: 52 On 14/03/17 15:53, Brian Dodge wrote: > Hi Daniel, > > Yes checkpatch.pl was telling us this. I didn't think we had the > "authority" to modify that file. You don't really need authority to propose changes (e.g. send a patch). I guess you might attract sharp words from a maintainer if the proposed change were conspicuously reckless or extremely short sighted ("my use case is the only one that really matters") but I don't see any risk of that here. Think of it like this: if folks with @arcticsand.com mail addresses don't try to document the vendor prefix, who will? > Is it OK if we put the > vendor-prefixes.txt change in the first patch (device tree bindings) or > so you think we should have an 0003 patch for just that? Personally I'd add it as a new patch but I'd make it the *first* patch in the series. Daniel. PS Top posting *is* something that will eventually attract sharp words from some maintainers ;-) > On 03/14/2017 06:16 AM, Daniel Thompson wrote: >> On 13/03/17 18:22, Olimpiu Dejeu wrote: >>> backlight: Add support for Arctic Sand LED backlight driver chips >>> This driver provides support for the Arctic Sand arc2c0608 chip, >>> and provides a framework to support future devices. >>> Signed-off-by: Olimpiu Dejeu >> >> Please could you also submit a patch to add arc to >> ./Documentation/devicetree/bindings/vendor-prefixes.txt. >> >> checkpatch.pl should have been asking you to do since v1 but only if >> you test the patch series against a clean kernel (tools such as aiaiai >> can help with this). >> >> However, once that is attended to: >> >> Reviewed-by: Daniel Thompson >> >> >> Daniel. >