Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752958AbdCNRDm (ORCPT ); Tue, 14 Mar 2017 13:03:42 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:35814 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbdCNRDi (ORCPT ); Tue, 14 Mar 2017 13:03:38 -0400 From: Kevin Hilman To: Neil Armstrong Cc: Sergei Shtylyov , Bartosz Golaszewski , Tejun Heo , Rob Herring , Mark Rutland , Michael Turquette , Patrick Titiano , linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ata: ahci: add support for DaVinci DM816 SATA controller Organization: BayLibre References: <1489422982-3461-1-git-send-email-bgolaszewski@baylibre.com> <1489422982-3461-3-git-send-email-bgolaszewski@baylibre.com> <7ab4b440-f9d0-22fa-f463-f4c5542e21e7@baylibre.com> Date: Tue, 14 Mar 2017 10:03:35 -0700 In-Reply-To: <7ab4b440-f9d0-22fa-f463-f4c5542e21e7@baylibre.com> (Neil Armstrong's message of "Tue, 14 Mar 2017 10:00:07 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1570 Lines: 52 Neil Armstrong writes: > On 03/14/2017 09:57 AM, Sergei Shtylyov wrote: >> Hello! >> >> On 3/13/2017 7:36 PM, Bartosz Golaszewski wrote: >> >>> This SATA controller is quite similar to the one present on the DA850 >>> SoC, but the PHY configuration is different and it supports two HBA >>> ports. >>> >>> The IP suffers from the same PMP issue the DA850 does - if we enable >>> PMP but don't use it - softreset fails. Appropriate workaround was >>> implemented in this driver as well. >>> >>> Signed-off-by: Bartosz Golaszewski >>> --- >>> drivers/ata/Kconfig | 9 +++ >>> drivers/ata/Makefile | 1 + >>> drivers/ata/ahci_dm816.c | 200 +++++++++++++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 210 insertions(+) >>> create mode 100644 drivers/ata/ahci_dm816.c >>> >>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig >>> index 70b57d2..7f59a7a 100644 >>> --- a/drivers/ata/Kconfig >>> +++ b/drivers/ata/Kconfig >>> @@ -118,6 +118,15 @@ config AHCI_DA850 >>> >>> If unsure, say N. >>> >>> +config AHCI_DM816 >>> + tristate "DaVinci DM816 AHCI SATA support" >> >> Is it really DaVinci? >> >>> + depends on ARCH_OMAP2PLUS >> >> Especially if it depends on OMAP... > > Hi Sergei, > > Yes it's a DaVinci family SoC, but shares a lot of IPs with the OMAP family. > Actually, this is more of an OMAP family, which shares some IP from DaVinci family I think in other parts of the kernel, we refer to this as TI 816x instead of using either DaVinci or OMAP. Kevin