Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753157AbdCNRG0 (ORCPT ); Tue, 14 Mar 2017 13:06:26 -0400 Received: from mail-wr0-f181.google.com ([209.85.128.181]:36297 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753101AbdCNRGS (ORCPT ); Tue, 14 Mar 2017 13:06:18 -0400 Date: Tue, 14 Mar 2017 17:06:14 +0000 From: Lee Jones To: Charles Keepax Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH RESEND 2/4] mfd: arizona: Display register addresses in hex Message-ID: <20170314170614.nxccpx6javtdiiye@dell> References: <1489051715-4774-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1489051715-4774-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1489051715-4774-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 41 On Thu, 09 Mar 2017, Charles Keepax wrote: > Register addresses are normally displayed in hex throughout the Arizona > driver. Update the arizona_poll_reg function to follow this convention. > > Signed-off-by: Charles Keepax > --- > drivers/mfd/arizona-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index e00f577..4cb34c3 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -245,7 +245,7 @@ static int arizona_poll_reg(struct arizona *arizona, > for (i = 0; i < timeout; i++) { > ret = regmap_read(arizona->regmap, reg, &val); > if (ret != 0) { > - dev_err(arizona->dev, "Failed to read reg %u: %d\n", > + dev_err(arizona->dev, "Failed to read reg 0x%x: %d\n", > reg, ret); > continue; > } > @@ -256,7 +256,7 @@ static int arizona_poll_reg(struct arizona *arizona, > usleep_range(1000, 5000); > } > > - dev_err(arizona->dev, "Polling reg %u timed out: %x\n", reg, val); > + dev_err(arizona->dev, "Polling reg 0x%x timed out: %x\n", reg, val); > return -ETIMEDOUT; > } > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog