Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753713AbdCNRj5 (ORCPT ); Tue, 14 Mar 2017 13:39:57 -0400 Received: from foss.arm.com ([217.140.101.70]:37872 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753440AbdCNRjx (ORCPT ); Tue, 14 Mar 2017 13:39:53 -0400 Subject: Re: [1/2] coresight: Disable the path only when the source is disabled To: Mathieu Poirier References: <1489073232-5093-2-git-send-email-suzuki.poulose@arm.com> Cc: Chunyan Zhang , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" From: Suzuki K Poulose Message-ID: <47520af0-9837-fadc-9657-eced36633325@arm.com> Date: Tue, 14 Mar 2017 17:39:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1496 Lines: 39 On 14/03/17 17:37, Mathieu Poirier wrote: > Hi Suzuki, > > On 14 March 2017 at 11:31, Mathieu Poirier wrote: >> From: "Suzuki K. Poulose" >> >> With a coresight tracing session, the components along the path >> from the source to sink are disabled after the source is disabled. >> However, if the source was not actually disabled due to active >> users, we should not disable the components in the path. >> >> Cc: Mathieu Poirier >> Signed-off-by: Suzuki K Poulose >> --- >> drivers/hwtracing/coresight/coresight.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c >> index 0c37356..34cd1ed 100644 >> --- a/drivers/hwtracing/coresight/coresight.c >> +++ b/drivers/hwtracing/coresight/coresight.c >> @@ -253,7 +253,8 @@ static int coresight_enable_source(struct coresight_device *csdev, u32 mode) >> return 0; >> } >> >> -static void coresight_disable_source(struct coresight_device *csdev) >> +/* coresight_disable_source: Returns true if the device has been disabled */ > > To be coherent with the rest of the file please use: > > /* > * coresight_disable_source: Returns true if the device has been disabled > */ > > I would have done the modification myself but 2/2 needs tending as well. > Ah, sorry about that, will resend it. Thanks for spotting. Suzuki