Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751829AbdCNSGx (ORCPT ); Tue, 14 Mar 2017 14:06:53 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56396 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbdCNSGv (ORCPT ); Tue, 14 Mar 2017 14:06:51 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B64E860C08 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org Subject: Re: [PATCH] ACPI / APEI: use setup_deferrable_timer To: Geliang Tang , "Rafael J. Wysocki" , Len Brown , Borislav Petkov References: <3afa5498142ef68256023257dad37b9f8352e65e.1489060803.git.geliangtang@gmail.com> Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org From: "Baicar, Tyler" Message-ID: Date: Tue, 14 Mar 2017 12:06:48 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <3afa5498142ef68256023257dad37b9f8352e65e.1489060803.git.geliangtang@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1175 Lines: 33 Works for me! On 3/10/2017 5:46 PM, Geliang Tang wrote: > Use setup_deferrable_timer() instead of init_timer_deferrable() to > simplify the code. > > Signed-off-by: Geliang Tang Tested-by: Tyler Baicar > --- > drivers/acpi/apei/ghes.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index b192b42..33ca196 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -1005,9 +1005,8 @@ static int ghes_probe(struct platform_device *ghes_dev) > > switch (generic->notify.type) { > case ACPI_HEST_NOTIFY_POLLED: > - ghes->timer.function = ghes_poll_func; > - ghes->timer.data = (unsigned long)ghes; > - init_timer_deferrable(&ghes->timer); > + setup_deferrable_timer(&ghes->timer, ghes_poll_func, > + (unsigned long)ghes); > ghes_add_timer(ghes); > break; > case ACPI_HEST_NOTIFY_EXTERNAL: -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.