Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752518AbdCNTYF (ORCPT ); Tue, 14 Mar 2017 15:24:05 -0400 Received: from mail-vk0-f47.google.com ([209.85.213.47]:35252 "EHLO mail-vk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752209AbdCNTYD (ORCPT ); Tue, 14 Mar 2017 15:24:03 -0400 MIME-Version: 1.0 In-Reply-To: <30f2ec3e-d0c8-8dd2-837f-3380237d843c@zytor.com> References: <20161108183956.4521-1-khuey@kylehuey.com> <20161108183956.4521-7-khuey@kylehuey.com> <30f2ec3e-d0c8-8dd2-837f-3380237d843c@zytor.com> From: Andy Lutomirski Date: Tue, 14 Mar 2017 12:23:40 -0700 Message-ID: Subject: Re: [PATCH v10 6/7] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID To: "H. Peter Anvin" Cc: Kyle Huey , "Robert O'Callahan" , Thomas Gleixner , Andy Lutomirski , Ingo Molnar , X86 ML , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Jeff Dike , Richard Weinberger , Alexander Viro , Shuah Khan , Dave Hansen , Borislav Petkov , Peter Zijlstra , Boris Ostrovsky , Len Brown , "Rafael J. Wysocki" , Dmitry Safonov , David Matlack , "linux-kernel@vger.kernel.org" , "user-mode-linux-devel@lists.sourceforge.net" , "open list:USER-MODE LINUX (UML)" , Linux FS Devel , "open list:KERNEL SELFTEST FRAMEWORK" , kvm list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 627 Lines: 18 On Tue, Mar 14, 2017 at 12:01 PM, H. Peter Anvin wrote: > and at least theoretically we > could be indirecting though the ->stack pointer for every one if gcc > can't tell it won't have changed (we really need to get thread_info > moved into the task_struct allocation and away from the kernel stack, > especially since on x86 the pointer is the same size as the vestigial > structure it points to.) Solved by use of time machine: commit 15f4eae70d365bba26854c90b6002aaabb18c8aa Author: Andy Lutomirski Date: Tue Sep 13 14:29:25 2016 -0700 x86: Move thread_info into task_struct :)