Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752579AbdCNToO (ORCPT ); Tue, 14 Mar 2017 15:44:14 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:48169 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751489AbdCNToN (ORCPT ); Tue, 14 Mar 2017 15:44:13 -0400 From: Robert Foss To: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org Cc: Robert Foss Subject: [PATCH RESEND v1] locking/ww_mutex: Prevent read of uninitialized memory Date: Tue, 14 Mar 2017 15:44:02 -0400 Message-Id: <20170314194402.15834-1-robert.foss@collabora.com> X-Mailer: git-send-email 2.11.0.453.g787f75f05 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 742 Lines: 25 On "missed ABBA deadlock" abba.result is read, but not initialized in all situations. Detected by CoverityScan, CID#1402035 ("Uninitialized scalar variable") Signed-off-by: Robert Foss --- kernel/locking/test-ww_mutex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/locking/test-ww_mutex.c b/kernel/locking/test-ww_mutex.c index 6b7abb334ca6..beb76693ccfa 100644 --- a/kernel/locking/test-ww_mutex.c +++ b/kernel/locking/test-ww_mutex.c @@ -196,7 +196,7 @@ static void test_abba_work(struct work_struct *work) static int test_abba(bool resolve) { - struct test_abba abba; + struct test_abba abba = { 0 }; struct ww_acquire_ctx ctx; int err, ret; -- 2.11.0.453.g787f75f05