Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752655AbdCNUSB (ORCPT ); Tue, 14 Mar 2017 16:18:01 -0400 Received: from mail.kernel.org ([198.145.29.136]:55978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbdCNUSA (ORCPT ); Tue, 14 Mar 2017 16:18:00 -0400 Date: Tue, 14 Mar 2017 15:17:55 -0500 From: Bjorn Helgaas To: Stephen Boyd Cc: Thomas Petazzoni , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PCI: aardvark: Remove msi-controller dt node probing Message-ID: <20170314201755.GG26264@bhelgaas-glaptop.roam.corp.google.com> References: <20170314190851.28203-1-stephen.boyd@linaro.org> <20170314193005.GC26264@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170314193005.GC26264@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2211 Lines: 60 On Tue, Mar 14, 2017 at 02:30:05PM -0500, Bjorn Helgaas wrote: > On Tue, Mar 14, 2017 at 12:08:51PM -0700, Stephen Boyd wrote: > > This code assigns variables that are never used. Remove them. > > > > Reported-by: Srinivas Kandagatla > > Cc: Thomas Petazzoni > > Signed-off-by: Stephen Boyd > > I love removing unused code! Applied to pci/host-aardvark for v4.12, > thanks! Actually, I applied Thomas' series [1], which does some additional cleanup and also removes this same code. So I'll just drop this one since it's redundant. Thanks again and sorry for my confusion. [1] https://patchwork.ozlabs.org/patch/733572/ > > --- > > drivers/pci/host/pci-aardvark.c | 8 -------- > > 1 file changed, 8 deletions(-) > > > > diff --git a/drivers/pci/host/pci-aardvark.c b/drivers/pci/host/pci-aardvark.c > > index 4fce494271cc..56e1aead65fc 100644 > > --- a/drivers/pci/host/pci-aardvark.c > > +++ b/drivers/pci/host/pci-aardvark.c > > @@ -917,8 +917,6 @@ static int advk_pcie_probe(struct platform_device *pdev) > > struct advk_pcie *pcie; > > struct resource *res; > > struct pci_bus *bus, *child; > > - struct msi_controller *msi; > > - struct device_node *msi_node; > > int ret, irq; > > > > pcie = devm_kzalloc(dev, sizeof(struct advk_pcie), GFP_KERNEL); > > @@ -962,12 +960,6 @@ static int advk_pcie_probe(struct platform_device *pdev) > > return ret; > > } > > > > - msi_node = of_parse_phandle(dev->of_node, "msi-parent", 0); > > - if (msi_node) > > - msi = of_pci_find_msi_chip_by_node(msi_node); > > - else > > - msi = NULL; > > - > > bus = pci_scan_root_bus_msi(dev, 0, &advk_pcie_ops, > > pcie, &pcie->resources, &pcie->msi); > > if (!bus) { > > -- > > 2.10.0.297.gf6727b0 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel