Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752891AbdCNU1S (ORCPT ); Tue, 14 Mar 2017 16:27:18 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:45330 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751972AbdCNU1Q (ORCPT ); Tue, 14 Mar 2017 16:27:16 -0400 Date: Tue, 14 Mar 2017 21:27:13 +0100 From: Thomas Petazzoni To: Bjorn Helgaas Cc: Stephen Boyd , Bjorn Helgaas , linux-pci@vger.kernel.org, Srinivas Kandagatla , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PCI: aardvark: Remove msi-controller dt node probing Message-ID: <20170314212713.1afb7a9f@free-electrons.com> In-Reply-To: <20170314193005.GC26264@bhelgaas-glaptop.roam.corp.google.com> References: <20170314190851.28203-1-stephen.boyd@linaro.org> <20170314193005.GC26264@bhelgaas-glaptop.roam.corp.google.com> Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 30 Hello, On Tue, 14 Mar 2017 14:30:05 -0500, Bjorn Helgaas wrote: > On Tue, Mar 14, 2017 at 12:08:51PM -0700, Stephen Boyd wrote: > > This code assigns variables that are never used. Remove them. > > > > Reported-by: Srinivas Kandagatla > > Cc: Thomas Petazzoni > > Signed-off-by: Stephen Boyd > > I love removing unused code! Applied to pci/host-aardvark for v4.12, > thanks! Why? I have already sent a patch that also does this (and much more!) a number of times already, and it has never been applied. See: [PATCH v3 1/3] pci: pci-aardvark: move to MSI handling using generic MSI support v1 on September 1st, 2016 v2 on December 23th, 2016 v3 on February 28th, 2017 Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com