Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753256AbdCNU7K (ORCPT ); Tue, 14 Mar 2017 16:59:10 -0400 Received: from mail-pg0-f46.google.com ([74.125.83.46]:33549 "EHLO mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753198AbdCNU7I (ORCPT ); Tue, 14 Mar 2017 16:59:08 -0400 Date: Tue, 14 Mar 2017 13:59:03 -0700 From: Brian Norris To: Chris Zhong Cc: linux-rockchip@lists.infradead.org, Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Thierry Reding Subject: Re: [PATCH 1/2] dt-bindings: Add INNOLUX P079ZCA panel bindings Message-ID: <20170314205901.GA26988@google.com> References: <1488502909-22160-1-git-send-email-zyw@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488502909-22160-1-git-send-email-zyw@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 46 Hi Chris, On Fri, Mar 03, 2017 at 09:01:48AM +0800, Chris Zhong wrote: > The Innolux P079ZCA is a 7.85" panel with a 768X1024 resolution and > connected to DSI using four lanes. > > Signed-off-by: Chris Zhong > --- > > .../bindings/display/panel/innolux,p079zca.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt b/Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt > new file mode 100644 > index 0000000..c40c8e4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt > @@ -0,0 +1,22 @@ > +Innolux P079ZCA 7.85" 768x1024 TFT LCD panel > + > +Required properties: > +- compatible: should be "innolux,p079zca" > +- power-supply: phandle of the regulator that provides the supply voltage > +- enable-gpios: panel enable gpio > + > +Optional properties: > +- backlight: phandle of the backlight device attached to the panel > + > +Example: > + > + &mipi_dsi { > + panel { > + compatible = "innolux,p079zca"; > + reg = <0>; Where's the documentation for this property? Brian > + power-supply = <...>; > + backlight = <&backlight>; > + enable-gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + }; > + };