Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbdCNVT5 (ORCPT ); Tue, 14 Mar 2017 17:19:57 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:26243 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdCNVT4 (ORCPT ); Tue, 14 Mar 2017 17:19:56 -0400 Subject: Re: [PATCH] firmware: ti_sci: fix strncat length check To: Arnd Bergmann , Nishanth Menon , Tero Kristo , Santosh Shilimkar References: <20170314211157.3424031-1-arnd@arndb.de> Cc: Dave Gerlach , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: "santosh.shilimkar@oracle.com" Organization: Oracle Corporation Message-ID: <4e3a448e-da7e-4da5-96bf-327da2a8c7d0@oracle.com> Date: Tue, 14 Mar 2017 14:19:18 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170314211157.3424031-1-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 18 On 3/14/17 2:11 PM, Arnd Bergmann wrote: > gcc-7 notices that the length we pass to strncat is wrong: > > drivers/firmware/ti_sci.c: In function 'ti_sci_probe': > drivers/firmware/ti_sci.c:204:32: error: specified bound 50 equals the size of the destination [-Werror=stringop-overflow=] > > Instead of the total length, we must pass the length of the > remaining space here. > > Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol") > Acked-by: Nishanth Menon > Signed-off-by: Arnd Bergmann > --- > Originally submitted on Jan 11, patch is still needed on Linux-4.11-rc2. Looks fine to me Arnd. Will you be applying it to SOC driver branch ? Acked-by: Santosh Shilimkar