Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753042AbdCNVsl (ORCPT ); Tue, 14 Mar 2017 17:48:41 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:62517 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751752AbdCNVsk (ORCPT ); Tue, 14 Mar 2017 17:48:40 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Tue, 14 Mar 2017 21:48:35 +0000 From: Chris Wilson To: Robert Foss Cc: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND v1] locking/ww_mutex: Prevent read of uninitialized memory Message-ID: <20170314214835.GP2118@nuc-i3427.alporthouse.com> References: <20170314194402.15834-1-robert.foss@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170314194402.15834-1-robert.foss@collabora.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 395 Lines: 12 On Tue, Mar 14, 2017 at 03:44:02PM -0400, Robert Foss wrote: > On "missed ABBA deadlock" abba.result is read, but not initialized > in all situations. > > Detected by CoverityScan, CID#1402035 ("Uninitialized scalar variable") It's unconditionally set by the worker, and only accessed by the parent after the flush_work() barrier. -Chris -- Chris Wilson, Intel Open Source Technology Centre