Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752482AbdCNWRH (ORCPT ); Tue, 14 Mar 2017 18:17:07 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34743 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbdCNWRF (ORCPT ); Tue, 14 Mar 2017 18:17:05 -0400 Date: Wed, 15 Mar 2017 07:17:01 +0900 From: Stafford Horne To: Geert Uytterhoeven Cc: "linux-kernel@vger.kernel.org" , Jonas Bonn , Christian Svensson , openrisc@lists.librecores.org, Ingo Molnar Subject: Re: [OpenRISC] [PATCH 3/3] openrisc: Export symbols needed by modules Message-ID: <20170314221701.GF2418@lianli.shorne-pla.net> References: <05e67e380f8a29ce479a180a3bbd145f30236b16.1489502779.git.shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1909 Lines: 57 On Tue, Mar 14, 2017 at 04:25:30PM +0100, Geert Uytterhoeven wrote: > Hi Stafford, > > On Tue, Mar 14, 2017 at 3:56 PM, Stafford Horne wrote: > > This was detected by allmodconfig, errors reported: > > > > ERROR: "empty_zero_page" [net/ceph/libceph.ko] undefined! > > ERROR: "__ucmpdi2" [lib/842/842_decompress.ko] undefined! > > ERROR: "empty_zero_page" [fs/nfs/objlayout/objlayoutdriver.ko] undefined! > > ERROR: "empty_zero_page" [fs/exofs/exofs.ko] undefined! > > ERROR: "empty_zero_page" [fs/crypto/fscrypto.ko] undefined! > > ERROR: "__ucmpdi2" [fs/btrfs/btrfs.ko] undefined! > > ERROR: "pm_power_off" [drivers/regulator/act8865-regulator.ko] undefined! > > > > Signed-off-by: Stafford Horne > > > --- a/arch/openrisc/kernel/or32_ksyms.c > > +++ b/arch/openrisc/kernel/or32_ksyms.c > > @@ -42,6 +42,11 @@ DECLARE_EXPORT(__muldi3); > > DECLARE_EXPORT(__ashrdi3); > > DECLARE_EXPORT(__ashldi3); > > DECLARE_EXPORT(__lshrdi3); > > +DECLARE_EXPORT(__ucmpdi2); > > + > > +extern unsigned long empty_zero_page[2048]; > > Can't you #include instead of adding a forward > declaration? Right, I can do this. In the end I was hoping to convert empty_zero_page to be more like parisc. which would put something like this mm/init.c unsigned long *empty_zero_page __read_mostly; EXPORT_SYMBOL(empty_zero_page); in init { empty_zero_page = get_memblock(PAGE_SIZE); } But I was going to wait until 4.12 for that change. -Stafford > > +EXPORT_SYMBOL(empty_zero_page); > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds