Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263632AbTEWE6j (ORCPT ); Fri, 23 May 2003 00:58:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263637AbTEWE6j (ORCPT ); Fri, 23 May 2003 00:58:39 -0400 Received: from pat.uio.no ([129.240.130.16]:4590 "EHLO pat.uio.no") by vger.kernel.org with ESMTP id S263632AbTEWE6i (ORCPT ); Fri, 23 May 2003 00:58:38 -0400 To: Andrew Morton Cc: viro@parcelfarce.linux.theplanet.co.uk, torvalds@transmeta.com, Andries.Brouwer@cwi.nl, linux-kernel@vger.kernel.org Subject: Re: [patch?] truncate and timestamps References: <20030523011751.GC14406@parcelfarce.linux.theplanet.co.uk> <20030522194211.4191e473.akpm@digeo.com> From: Trond Myklebust Date: 23 May 2003 07:11:33 +0200 In-Reply-To: <20030522194211.4191e473.akpm@digeo.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Honest Recruiter) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-MailScanner-Information: Please contact postmaster@uio.no for more information X-UiO-MailScanner: Found to be clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 913 Lines: 21 >>>>> " " == Andrew Morton writes: > I assume every foo_truncate() is doing inode-> i_mtime = inode->i_ctime = CURRENT_TIME; > mark_inode_dirty(inode); > and as Andries says, we can probably pull all that up to the > VFS level. No. Please do not assume that the above is equivalent to calling notify_change() with ATTR_MTIME|ATTR_CTIME. NFS tends to leave the above to the server side, since the clocks may be desynchronized between client and server. As far as NFS is concerned, we should only be setting ATTR_*TIME if/when the *user* specifies it through a utimes() call or something like that. Cheers, Trond - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/