Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752000AbdCOHUq (ORCPT ); Wed, 15 Mar 2017 03:20:46 -0400 Received: from mailproxy03.manitu.net ([217.11.48.67]:43976 "EHLO mailproxy03.manitu.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751573AbdCOHTe (ORCPT ); Wed, 15 Mar 2017 03:19:34 -0400 Subject: Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver To: Akshay Bhat References: <1484680922-25813-1-git-send-email-akshay.bhat@timesys.com> <1484680922-25813-2-git-send-email-akshay.bhat@timesys.com> <234d9e75-0083-b8b4-c781-add653fdb550@grandegger.com> <3dbf8748-9d04-0f21-0e95-448d7a72e7d5@timesys.com> <41439729-42d0-d883-2801-2d3607f2aeab@grandegger.com> Cc: Akshay Bhat , mkl@pengutronix.de, linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Wolfgang Grandegger Message-ID: <15211aa1-7396-391d-de15-b10ff3a3382d@grandegger.com> Date: Wed, 15 Mar 2017 08:19:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1987 Lines: 57 Hello Akshay, Am 15.03.2017 um 05:44 schrieb Akshay Bhat: > Hi Wolfgang, > > On Tue, Mar 14, 2017 at 2:08 PM, Wolfgang Grandegger wrote: > ...snip.... >>> /////disconnect cable >>> can0 20000088 [8] 00 00 00 19 00 00 28 00 ERRORFRAME >>> protocol-violation{{}{acknowledge-slot}} >>> bus-error >>> error-counter-tx-rx{{40}{0}} >>> can0 20000088 [8] 00 00 00 19 00 00 58 00 ERRORFRAME >>> protocol-violation{{}{acknowledge-slot}} >>> bus-error >>> error-counter-tx-rx{{88}{0}} >>> can0 20000088 [8] 00 00 00 19 00 00 80 00 ERRORFRAME >>> protocol-violation{{}{acknowledge-slot}} >>> bus-error >>> error-counter-tx-rx{{128}{0}} >> >> >> TX error warning is missing. >> > > This support was missing in the driver, added in V4 patch. > >>> can0 2000008C [8] 00 20 00 19 00 00 80 00 ERRORFRAME >>> controller-problem{tx-error-passive} >>> protocol-violation{{}{acknowledge-slot}} >>> bus-error >>> error-counter-tx-rx{{128}{0}} >> >> >> Here "tx-error-passiv" is packed with a bus error. What I'm looking for are >> state change messages similar to: >> >> can0 20000204 [8] 00 08 00 00 00 00 60 00 ERRORFRAME >> controller-problem{tx-error-warning} >> state-change{tx-error-warning} >> error-counter-tx-rx{{96}{0}} >> can0 20000204 [8] 00 30 00 00 00 00 80 00 ERRORFRAME >> controller-problem{tx-error-passive} >> state-change{tx-error-passive} >> error-counter-tx-rx{{128}{0} >> >> They should always come, even with "berr-reporting off". >> > > HI-3110 has only 1 bus error interrupt. There is no dedicated state > change interrupts like other controllers. To double check: Could you please read INTF, ERR and STATF at the beginning of the ISR and print it out (using dev_dbg and fiends). Then run a test with no cable connected and bus error reporting off. Wolfgang.