Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752694AbdCOJBD (ORCPT ); Wed, 15 Mar 2017 05:01:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:56456 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbdCOJBA (ORCPT ); Wed, 15 Mar 2017 05:01:00 -0400 Date: Wed, 15 Mar 2017 10:00:51 +0100 From: Petr Mladek To: Steven Rostedt Cc: Aleksey Makarov , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Sudeep Holla , Greg Kroah-Hartman , Peter Hurley , Jiri Slaby , Robin Murphy , "Nair, Jayachandran" , Sergey Senozhatsky Subject: Re: [PATCH v2 2/3] printk: rename selected_console -> preferred_console Message-ID: <20170315090050.GC2538@linux.suse> References: <20170302131153.22733-1-aleksey.makarov@linaro.org> <20170302131153.22733-3-aleksey.makarov@linaro.org> <20170302100153.410acdc9@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170302100153.410acdc9@gandalf.local.home> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1239 Lines: 32 On Thu 2017-03-02 10:01:53, Steven Rostedt wrote: > On Thu, 2 Mar 2017 16:11:33 +0300 > Aleksey Makarov wrote: > > > The variable selected_console is set in __add_preferred_console() > > to point to the last console parameter that was added to the > > console_cmdline array. > > > > Rename it to preferred_console so that the name reflects the usage. > > As I said previously, I prefer "selected_console" but since > "__add_preferred_console()" sets it, I'm fine with this change. > Although, I would probably have changed that function to > "__add_selected_console()" :) If I get it correctly, the selected_console/preferred_console value is used to keep the console first in the console_drivers list. IMHO, the main effect is that each line will first appear on this console, see call_console_drivers(). But the message will still appear also on all other enabled consoles. From this point, the name "preferred" sounds better to me. More consoles are selected (enabled) and only one is preferred (first). Well, I am not a native speaker and might be wrong. Also it is possible that I missed something. Anyway, the change looks fine to me. Acked-by: Petr Mladek Best Regards, Petr