Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751816AbdCOJQ7 (ORCPT ); Wed, 15 Mar 2017 05:16:59 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47003 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbdCOJQ5 (ORCPT ); Wed, 15 Mar 2017 05:16:57 -0400 Date: Wed, 15 Mar 2017 14:45:59 +0530 From: "Naveen N. Rao" To: Arnaldo Carvalho de Melo Cc: Michael Ellerman , Masami Hiramatsu , Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ananth N Mavinakayanahalli Subject: Re: [PATCH v5 2/5] powerpc: kretprobes: override default function entry offset References: <53bcae5a711eab803c9c3210110e8a464df34202.1488961018.git.naveen.n.rao@linux.vnet.ibm.com> <87o9xcujzi.fsf@concordia.ellerman.id.au> <20170308142412.GI11046@naverao1-tp.localdomain> <20170308142916.GA3035@kernel.org> <20170308164644.GK11046@naverao1-tp.localdomain> <87a88vuf9p.fsf@concordia.ellerman.id.au> <20170314131839.GD3089@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170314131839.GD3089@kernel.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-TM-AS-MML: disable x-cbid: 17031509-0044-0000-0000-000002372E03 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17031509-0045-0000-0000-000006B9C01D Message-Id: <20170315091559.GF20400@naverao1-tp.localdomain> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-15_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703150073 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1599 Lines: 38 On 2017/03/14 10:18AM, Arnaldo Carvalho de Melo wrote: > Em Thu, Mar 09, 2017 at 05:37:38PM +1100, Michael Ellerman escreveu: > > "Naveen N. Rao" writes: > > > On 2017/03/08 11:29AM, Arnaldo Carvalho de Melo wrote: > > >> > I wasn't sure if you were planning on picking up KPROBES_ON_FTRACE for > > >> > v4.11. If so, it would be good to take this patch through the powerpc > > >> > tree. Otherwise, this can go via Ingo's tree. > > >> > > >> If you guys convince Ingo that this should go _now_, then just cherry > > >> pick what was merged into tip/perf/core that is needed for the arch > > >> specific stuff and go from there. > > > > > > Ok, in hindsight, I think Michael's concern was actually for v4.12 > > > > Yes I was talking about 4.12, sorry I thought that was implied :) > > > > > itself, in which case this particular patch can go via powerpc tree, > > > while the rest of the patches in this series can go via your tree. > > > > > > Michael? > > > > Yeah I think that's the easiest option. The function will be temporarily > > unused until the two trees are merged, but I think that's fine. > > Ok, done that, now compile testing building it in my > multi-distro/x-build containers. Thanks, Arnaldo! I did however notice that you don't seem to have applied Patch 1/5 from this series: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1347858.html That patch is needed to ensure perf continues to work when ftrace README advertises support for ref_reloc_sym+offset for kretprobes. Can you please apply that as well? - Naveen