Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbdCOJ4t (ORCPT ); Wed, 15 Mar 2017 05:56:49 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:35491 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752005AbdCOJ4r (ORCPT ); Wed, 15 Mar 2017 05:56:47 -0400 MIME-Version: 1.0 In-Reply-To: <77d635877e765a6b4b0935debfe5836e554572c0.1489015238.git.julia@ni.com> References: <77d635877e765a6b4b0935debfe5836e554572c0.1489015238.git.julia@ni.com> From: Linus Walleij Date: Wed, 15 Mar 2017 10:56:45 +0100 Message-ID: Subject: Re: [PATCH 07/19] gpio: bcm-kona: make use of raw_spinlock variants To: Julia Cartwright Cc: Ray Jui , Alexandre Courbot , Florian Fainelli , Scott Branden , bcm-kernel-feedback-list , "linux-kernel@vger.kernel.org" , Thomas Gleixner , "linux-gpio@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 670 Lines: 17 On Thu, Mar 9, 2017 at 5:21 PM, Julia Cartwright wrote: > The bcm-kona gpio driver currently implements an irq_chip for handling > interrupts; due to how irq_chip handling is done, it's necessary for the > irq_chip methods to be invoked from hardirq context, even on a a > real-time kernel. Because the spinlock_t type becomes a "sleeping" > spinlock w/ RT kernels, it is not suitable to be used with irq_chips. > > A quick audit of the operations under the lock reveal that they do only > minimal, bounded work, and are therefore safe to do under a raw spinlock. > > Signed-off-by: Julia Cartwright Patch applied. Yours, Linus Walleij