Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753035AbdCOKFa (ORCPT ); Wed, 15 Mar 2017 06:05:30 -0400 Received: from mail-lf0-f52.google.com ([209.85.215.52]:35183 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbdCOKF2 (ORCPT ); Wed, 15 Mar 2017 06:05:28 -0400 Subject: Re: [PATCH] net: sun: sungem: rix a possible null dereference To: Philippe Reynes , davem@davemloft.net, mugunthanvnm@ti.com, jarod@redhat.com, felipe.balbi@linux.intel.com, edumazet@google.com, fw@strlen.de, dan.carpenter@oracle.com References: <1489526601-9423-1-git-send-email-tremyfr@gmail.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <88708a0d-7b8a-b1d7-ee66-fd51c6bfe0fe@cogentembedded.com> Date: Wed, 15 Mar 2017 13:05:24 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1489526601-9423-1-git-send-email-tremyfr@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 559 Lines: 19 Hello! On 3/15/2017 12:23 AM, Philippe Reynes wrote: > The function gem_begin_auto_negotiation dereference > the pointer ep before testing if it's null. This > patch add a check on ep before dereferencing it. > > This issue was added by the patch 92552fdd557: > "net: sun: sungem: use new api ethtool_{get|set}_link_ksettings". There's Fixes: tag for that now, described in Documentation/process/submitting-patches.rst... > Reported-by: Dan Carpenter > Signed-off-by: Philippe Reynes [...] MBR, Sergei