Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753034AbdCOKNb (ORCPT ); Wed, 15 Mar 2017 06:13:31 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:34425 "EHLO mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752027AbdCOKN3 (ORCPT ); Wed, 15 Mar 2017 06:13:29 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Linus Walleij Date: Wed, 15 Mar 2017 11:13:27 +0100 Message-ID: Subject: Re: [PATCH 18/19] pinctrl: sirf: atlas7: make use of raw_spinlock variants To: Julia Cartwright Cc: Barry Song , "linux-kernel@vger.kernel.org" , Thomas Gleixner , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 678 Lines: 18 On Thu, Mar 9, 2017 at 5:22 PM, Julia Cartwright wrote: > The sirf atlas7 pinctrl drivers currently implement an irq_chip for > handling interrupts; due to how irq_chip handling is done, it's > necessary for the irq_chip methods to be invoked from hardirq context, > even on a a real-time kernel. Because the spinlock_t type becomes a > "sleeping" spinlock w/ RT kernels, it is not suitable to be used with > irq_chips. > > A quick audit of the operations under the lock reveal that they do only > minimal, bounded work, and are therefore safe to do under a raw spinlock. > > Signed-off-by: Julia Cartwright Patch applied. Yours, Linus Walleij