From: Milian Wolff <milian.wolff@kdab.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, Linux-kernel@vger.kernel.org,
        ak@linux.intel.com, kan.liang@intel.com
Subject: Re: [PATCH v4 0/5] perf report: Show inline stack
Date: Tue, 14 Mar 2017 13:59:55 +0100
Message-ID: <148956608.Gr0Z3zOxTt@milian-kdab2>
Organization: KDAB
In-Reply-To: <1488537785-10684-1-git-send-email-yao.jin@linux.intel.com>
References: <1488537785-10684-1-git-send-email-yao.jin@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 952
Lines: 21

On Friday, March 3, 2017 11:43:00 AM CET Jin Yao wrote:
> v4: Remove the options "--inline-line" and "--inline-name". Just use
>     a new option "--inline" to print the inline function information.
>     The policy is if the inline function name can be resolved then
>     print the name in priority. If the name can't be resolved, then
>     print the source line number.

This is still wrong from a usability POV. I may want to see the file/line for 
entry that have a name. And actually, there are afaik no situations where you 
could have a file/line but not a symbol name.

Again, why don't you align this with the other non-inlined frames, and honor 
the grouping setting? Check whether we group by address (then display file/
line), or by function (then display the function name).

Bye
-- 
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts