Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511AbdCOMRf (ORCPT ); Wed, 15 Mar 2017 08:17:35 -0400 Received: from mail-ot0-f173.google.com ([74.125.82.173]:34440 "EHLO mail-ot0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752663AbdCOMRD (ORCPT ); Wed, 15 Mar 2017 08:17:03 -0400 From: Sumit Saxena References: <20170315021431.13107-1-andi@firstfloor.org> <20170315021431.13107-7-andi@firstfloor.org> In-Reply-To: <20170315021431.13107-7-andi@firstfloor.org> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQDaAtFjmXf+NJYqApHceGsvKcSNDgIlBGJ2o3Xd9ZA= Date: Wed, 15 Mar 2017 17:47:00 +0530 Message-ID: Subject: RE: [PATCH 6/7] megasas: Remove expensive inline from megasas_return_cmd To: Andi Kleen , akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, Andi Kleen , "PDL,MEGARAIDLINUX" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1602 Lines: 49 >-----Original Message----- >From: megaraidlinux.pdl@broadcom.com >[mailto:megaraidlinux.pdl@broadcom.com] On Behalf Of Andi Kleen >Sent: Wednesday, March 15, 2017 7:45 AM >To: akpm@linux-foundation.org >Cc: linux-kernel@vger.kernel.org; Andi Kleen; >megaraidlinux.pdl@broadcom.com >Subject: [PATCH 6/7] megasas: Remove expensive inline from >megasas_return_cmd > >From: Andi Kleen > >Remove an inline from a fairly big function that is used often. >It's unlikely that calling or not calling it makes a lot of difference. > >Saves around 8k text in my kernel. > > text data bss dec hex filename >9047801 5367568 11116544 25531913 1859609 >vmlinux-before-megasas >9039417 5367568 11116544 25523529 1857549 vmlinux-megasas > >Cc: megaraidlinux.pdl@broadcom.com >Signed-off-by: Andi Kleen >--- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c >b/drivers/scsi/megaraid/megaraid_sas_base.c >index 7ac9a9ee9bd4..55b71de3fb1f 100644 >--- a/drivers/scsi/megaraid/megaraid_sas_base.c >+++ b/drivers/scsi/megaraid/megaraid_sas_base.c >@@ -244,7 +244,7 @@ struct megasas_cmd *megasas_get_cmd(struct >megasas_instance > * @instance: Adapter soft state > * @cmd: Command packet to be returned to free command pool > */ >-inline void >+void > megasas_return_cmd(struct megasas_instance *instance, struct megasas_cmd >*cmd) { > unsigned long flags; Acked-by: Sumit Saxena >-- >2.9.3 >