Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753507AbdCOMjh (ORCPT ); Wed, 15 Mar 2017 08:39:37 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:7157 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbdCOMj1 (ORCPT ); Wed, 15 Mar 2017 08:39:27 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 15 Mar 2017 05:36:57 -0700 Subject: Re: [PATCH] ARM: tegra: Select SOC_TEGRA_PMC to fix linking error To: Krzysztof Kozlowski , Thierry Reding , Linus Walleij , "Olof Johansson" , Joseph Lo , , , References: <20170311202614.6052-1-krzk@kernel.org> From: Jon Hunter Message-ID: <0aaf8ec2-16da-9e3a-e156-a8edeb627f25@nvidia.com> Date: Wed, 15 Mar 2017 12:39:13 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170311202614.6052-1-krzk@kernel.org> X-Originating-IP: [10.21.132.151] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2381 Lines: 72 On 11/03/17 20:26, Krzysztof Kozlowski wrote: > It is possible to create a ARMv7 config with ARCH_TEGRA but without any > SoC specific flavors. Such configs fails because mach-tegra/pm.c is > compiled always and it references SOC_TEGRA_PMC driver: > > arch/arm/mach-tegra/built-in.o: In function `tegra_pm_set': > arch/arm/mach-tegra/pm.c:188: undefined reference to `tegra_pmc_enter_suspend_mode' > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/mach-tegra/Kconfig | 1 + > drivers/soc/tegra/Kconfig | 4 ---- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig > index 329f01c5b6f8..eabf101979cc 100644 > --- a/arch/arm/mach-tegra/Kconfig > +++ b/arch/arm/mach-tegra/Kconfig > @@ -13,5 +13,6 @@ menuconfig ARCH_TEGRA > select ARCH_HAS_RESET_CONTROLLER > select RESET_CONTROLLER > select SOC_BUS > + select SOC_TEGRA_PMC > help > This enables support for NVIDIA Tegra based systems. > diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig > index 208d6edb3fdb..cfde6d666d4b 100644 > --- a/drivers/soc/tegra/Kconfig > +++ b/drivers/soc/tegra/Kconfig > @@ -12,7 +12,6 @@ config ARCH_TEGRA_2x_SOC > select PINCTRL_TEGRA20 > select PL310_ERRATA_727915 if CACHE_L2X0 > select PL310_ERRATA_769419 if CACHE_L2X0 > - select SOC_TEGRA_PMC > select TEGRA_TIMER > help > Support for NVIDIA Tegra AP20 and T20 processors, based on the > @@ -24,7 +23,6 @@ config ARCH_TEGRA_3x_SOC > select ARM_ERRATA_764369 if SMP > select PINCTRL_TEGRA30 > select PL310_ERRATA_769419 if CACHE_L2X0 > - select SOC_TEGRA_PMC > select TEGRA_TIMER > help > Support for NVIDIA Tegra T30 processor family, based on the > @@ -35,7 +33,6 @@ config ARCH_TEGRA_114_SOC > select ARM_ERRATA_798181 if SMP > select HAVE_ARM_ARCH_TIMER > select PINCTRL_TEGRA114 > - select SOC_TEGRA_PMC > select TEGRA_TIMER > help > Support for NVIDIA Tegra T114 processor family, based on the > @@ -45,7 +42,6 @@ config ARCH_TEGRA_124_SOC > bool "Enable support for Tegra124 family" > select HAVE_ARM_ARCH_TIMER > select PINCTRL_TEGRA124 > - select SOC_TEGRA_PMC > select TEGRA_TIMER > help > Support for NVIDIA Tegra T124 processor family, based on the Thanks for the patch. Acked-by: Jon Hunter Cheers Jon -- nvpublic