Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753473AbdCONeI (ORCPT ); Wed, 15 Mar 2017 09:34:08 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:53352 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbdCONdh (ORCPT ); Wed, 15 Mar 2017 09:33:37 -0400 Date: Wed, 15 Mar 2017 13:33:18 +0000 From: Mark Brown To: Charles Keepax Cc: Daniel Baluta , lgirdwood@gmail.com, tiwai@suse.com, patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, shengjiu.wang@freescale.com, mihai.serban@nxp.com, viorel.suman@nxp.com Message-ID: <20170315133318.qo7fpoffmyh2chmz@sirena.org.uk> References: <1489510622-30981-1-git-send-email-daniel.baluta@nxp.com> <20170315091901.GF6986@localhost.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c5756h73xogkajuw" Content-Disposition: inline In-Reply-To: <20170315091901.GF6986@localhost.localdomain> X-Cookie: No shirt, no shoes, no service. User-Agent: NeoMutt/20161126 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH] ASoC: wm8960: Use physical width for bclk X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1591 Lines: 41 --c5756h73xogkajuw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 15, 2017 at 09:19:01AM +0000, Charles Keepax wrote: > On Tue, Mar 14, 2017 at 06:57:02PM +0200, Daniel Baluta wrote: > > - wm8960->bclk = snd_soc_params_to_bclk(params); > > + wm8960->bclk = params_physical_width(params) * > > + params_channels(params) * params_rate(params); > > if (params_channels(params) == 1) > > wm8960->bclk *= 2; > Would quite like to see Mark's thoughts on this. Feels a bit to > me (although I am not certain) like we are solving the problem in > the wrong place, isn't this really setting the desired BCLK and > then in wm8960_configure_clocking we should set the lowest BCLK > we can that is greater than or equal to the desired. Exactly, this is the wrong fix in the wrong place - if this is something we want to do we should be doing it in the shared functions so all CODECs get the same behaviour but really I think Charles' suggestion makes more sense. --c5756h73xogkajuw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAljJQp0ACgkQJNaLcl1U h9Cv0gf/a8ShsGPV26/iBsJOD1gVi7D/XkPV6qoqKhaq3KeM9F8QlaJfGFCevfcz A/YdOJgxRI/kW6bq/9zpebXKUeVY3/t2YfuKeNY5YIfwwhSuQPjaxPWsStTbiMO7 Eb0fppv6E1cAWC7+5WWP6IZPaAtRMbJQqyGqrGXszbqxWESkBtrC/EwakZnXZJwM JpjxCNybVxCCybMCLO7kxz8O8EFKHg4DFIhBuwvLMYD8Hqc9JaAGd/2q8O9RK4ZU h1f0/ZsZIZTiK2yyfgImYRLX+pGF3YaSo5YWd7iM/wIVXDo/wgRiPwWeWPd3DHRt z1pkDItSFMHFmx6vnrNHMXrEZ5zAKw== =wX7S -----END PGP SIGNATURE----- --c5756h73xogkajuw--