Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752555AbdCOQef convert rfc822-to-8bit (ORCPT ); Wed, 15 Mar 2017 12:34:35 -0400 Received: from gloria.sntech.de ([95.129.55.99]:49616 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183AbdCOQeb (ORCPT ); Wed, 15 Mar 2017 12:34:31 -0400 From: Heiko Stuebner To: John Keeping Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 3/4] pinctrl: rockchip: split out verification of mux settings Date: Wed, 15 Mar 2017 17:34:21 +0100 Message-ID: <5070254.AaMND3ln5I@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-1-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <20170313183813.3582-4-john@metanate.com> References: <20170313183813.3582-1-john@metanate.com> <20170313183813.3582-4-john@metanate.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 565 Lines: 11 Am Montag, 13. M?rz 2017, 18:38:12 CET schrieb John Keeping: > We need to avoid calling regmap functions from irq handlers, so the next > commit is going to move the call to rockchip_set_mux() into an > irq_bus_sync_unlock handler. But we can't return an error from there so > we still need to check the settings from rockchip_irq_set_type() and we > will use this new rockchip_verify_mux() function from there. > > Signed-off-by: John Keeping straightforward separation of the verification code Reviewed-by: Heiko Stuebner