Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753441AbdCOR0s (ORCPT ); Wed, 15 Mar 2017 13:26:48 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:53406 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753167AbdCOR0q (ORCPT ); Wed, 15 Mar 2017 13:26:46 -0400 Message-ID: <1489598802.2387.25.camel@HansenPartnership.com> Subject: Re: [scsi] scsi: ufs: don't check unsigned type for a negative value From: James Bottomley To: Subhash Jadavani , Tomas Winkler Cc: "Martin K . Petersen" , Vinayak Holikatti , Christoph Hellwig , Yaniv Gardi , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 15 Mar 2017 10:26:42 -0700 In-Reply-To: References: <20170312102202.9889-1-tomas.winkler@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1327 Lines: 39 On Mon, 2017-03-13 at 17:19 -0700, Subhash Jadavani wrote: > On 2017-03-12 03:22, Tomas Winkler wrote: > > Fix compilation warning > > > > drivers/scsi/ufs/ufshcd.c:7645:13: warning: comparison of unsigned > > expression < 0 is always false [-Wtype-limits] > > if ((value < UFS_PM_LVL_0) || (value >= UFS_PM_LVL_MAX)) > > > > Signed-off-by: Tomas Winkler > > --- > > drivers/scsi/ufs/ufshcd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > > index 1359913bf840..e8c26e6e6237 100644 > > --- a/drivers/scsi/ufs/ufshcd.c > > +++ b/drivers/scsi/ufs/ufshcd.c > > @@ -7642,7 +7642,7 @@ static inline ssize_t > > ufshcd_pm_lvl_store(struct > > device *dev, > > if (kstrtoul(buf, 0, &value)) > > return -EINVAL; > > > > - if ((value < UFS_PM_LVL_0) || (value >= UFS_PM_LVL_MAX)) > > + if (value >= UFS_PM_LVL_MAX) > > return -EINVAL; > > > > spin_lock_irqsave(hba->host->host_lock, flags); > > LGTM. > Reviewed-by: Subhash Jadavani Mis-spelling someone else's email can be cut and paste; mis-spelling your own might be the early indications of an identity crisis. We do cut and paste these tags, so getting your own name right for the purposes of git history is useful. James