Date: Fri, 23 May 2003 03:04:09 -0700
From: Andrew Morton <akpm@digeo.com>
To: "David S. Miller" <davem@redhat.com>
Cc: rmk@arm.linux.org.uk, LW@KARO-electronics.de, linux-kernel@vger.kernel.org,
       torvalds@transmeta.com
Subject: Re: [patch] cache flush bug in mm/filemap.c (all kernels >=
 2.5.30(at least))
Message-Id: <20030523030409.664c9b3a.akpm@digeo.com>
In-Reply-To: <20030523.024922.118612798.davem@redhat.com>
References: <20030522151156.C12171@flint.arm.linux.org.uk>
	<1053676924.30675.2.camel@rth.ninka.net>
	<20030523021204.4e3a4954.akpm@digeo.com>
	<20030523.024922.118612798.davem@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 875
Lines: 22

"David S. Miller" <davem@redhat.com> wrote:
>
>    From: Andrew Morton <akpm@digeo.com>
>    Date: Fri, 23 May 2003 02:12:04 -0700
>    
>    install_page() is prefaulting pages into pagetables, so perhaps it should
>    have an update_mmu_cache()?
> 
> I agree.  Someone should take a close look at the do_file_page()
> code paths to make sure that's still kosher after such a change.

What would one be looking for?  I don't know what the sideeffects of
update_mmu_cache() might be.

It looks to be the same as do_no_page() though: the update_mmu_cache() is
the last substantive thing which happens in the fault or the syscall.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/