Date: Wed, 15 Mar 2017 14:07:20 -0500
From: Julia Cartwright <julia@ni.com>
To: Lee Jones <lee.jones@linaro.org>
CC: <linux-kernel@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 14/19] mfd: t7l66xb: make use of raw_spinlock variants
Message-ID: <20170315190720.GE682@jcartwri.amer.corp.natinst.com>
References: <cover.1489015238.git.julia@ni.com>
 <72bbb1d0c4a9ae4c4f6d9dfadfdf870a03c522e0.1489015238.git.julia@ni.com>
 <20170315111744.nb67cjfkjwtrjvcf@dell>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
In-Reply-To: <20170315111744.nb67cjfkjwtrjvcf@dell>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1327
Lines: 32

On Wed, Mar 15, 2017 at 11:17:44AM +0000, Lee Jones wrote:
> On Thu, 09 Mar 2017, Julia Cartwright wrote:
> 
> > The t7l66xb mfd driver currently implements an irq_chip for handling
> > interrupts; due to how irq_chip handling is done, it's necessary for the
> > irq_chip methods to be invoked from hardirq context, even on a a
> > real-time kernel.  Because the spinlock_t type becomes a "sleeping"
> > spinlock w/ RT kernels, it is not suitable to be used with irq_chips.
> > 
> > A quick audit of the operations under the lock reveal that they do only
> > minimal, bounded work, and are therefore safe to do under a raw spinlock.
> > 
> > Signed-off-by: Julia Cartwright <julia@ni.com>
> > ---
> >  drivers/mfd/t7l66xb.c | 20 ++++++++++----------
> >  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> Can the 3 MFD patches in this set be applied on their own, or is there
> a dependency somewhere else in the set?

All of the patches are completely independent, so may be applied on
their own.

> NB: It's normally a good idea to send the set to everyone, or at the
> very least, the 00/00th patch.

Sorry I neglected to CC.  I'll be posting a v2 with the patches that
haven't yet hit next (as of tomorrow, likely), with a revised version of
the coccinelle patch, and will CC you on the coverletter.

Thanks!
   Julia