Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753217AbdCOTRl (ORCPT ); Wed, 15 Mar 2017 15:17:41 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:45760 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbdCOTRk (ORCPT ); Wed, 15 Mar 2017 15:17:40 -0400 From: Gregory CLEMENT To: Ralph Sennhauser Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] ARM: dts: mvebu: linksys: enable buffer manager support References: <20170308053312.29243-1-ralph.sennhauser@gmail.com> Date: Wed, 15 Mar 2017 20:17:35 +0100 In-Reply-To: <20170308053312.29243-1-ralph.sennhauser@gmail.com> (Ralph Sennhauser's message of "Wed, 8 Mar 2017 06:33:12 +0100") Message-ID: <8760jafiy8.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3818 Lines: 146 Hi Ralph, On mer., mars 08 2017, Ralph Sennhauser wrote: > Add appropriate properties to devices in the Linksys WRT AC Series for the > mvneta driver to use hardware buffer management. > > Also update "soc" ranges property and set the status of bm and bm-bppi > to "okay" (SRAM). > > Signed-off-by: Ralph Sennhauser > --- > arch/arm/boot/dts/armada-385-linksys.dtsi | 17 ++++++++++++++++- > arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 17 ++++++++++++++++- > 2 files changed, 32 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi > index df47bf1..4aac375 100644 > --- a/arch/arm/boot/dts/armada-385-linksys.dtsi > +++ b/arch/arm/boot/dts/armada-385-linksys.dtsi > @@ -59,7 +59,8 @@ > ranges = MBUS_ID(0x01, 0x1d) 0 0xfff00000 0x100000 > MBUS_ID(0x09, 0x19) 0 0xf1100000 0x10000 > - MBUS_ID(0x09, 0x15) 0 0xf1110000 0x10000>; > + MBUS_ID(0x09, 0x15) 0 0xf1110000 0x10000 > + MBUS_ID(0x0c, 0x04) 0 0xf1200000 0x100000>; > > internal-regs { > i2c@11000 { > @@ -88,6 +89,9 @@ > ethernet@70000 { > status = "okay"; > phy-mode = "rgmii-id"; > + buffer-manager = <&bm>; > + bm,pool-long = <1>; > + bm,pool-short = <3>; > fixed-link { > speed = <1000>; > full-duplex; > @@ -97,6 +101,9 @@ > ethernet@34000 { > status = "okay"; > phy-mode = "sgmii"; > + buffer-manager = <&bm>; > + bm,pool-long = <0>; > + bm,pool-short = <3>; Any reason to reuse the same pool than the other port? As only two ports are used here, then each of them can have use 2 of the 4 availables pools. > fixed-link { > speed = <1000>; > full-duplex; > @@ -159,6 +166,10 @@ > status = "okay"; > }; > > + bm@c8000 { > + status = "okay"; > + }; > + > /* USB part of the eSATA/USB 2.0 port */ > usb@58000 { > status = "okay"; > @@ -241,6 +252,10 @@ > }; > }; > > + bm-bppi { > + status = "okay"; > + }; > + > pcie-controller { > status = "okay"; > > diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts > index 3744ba3..b188a4dc 100644 > --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts > +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts > @@ -71,7 +71,8 @@ > ranges = MBUS_ID(0x01, 0x1d) 0 0 0xfff00000 0x100000 > MBUS_ID(0x09, 0x09) 0 0 0xf1100000 0x10000 > - MBUS_ID(0x09, 0x05) 0 0 0xf1110000 0x10000>; > + MBUS_ID(0x09, 0x05) 0 0 0xf1110000 0x10000 > + MBUS_ID(0x0c, 0x04) 0 0 0xf1200000 0x100000>; > > internal-regs { > > @@ -95,6 +96,9 @@ > pinctrl-names = "default"; > status = "okay"; > phy-mode = "rgmii-id"; > + buffer-manager = <&bm>; > + bm,pool-long = <0>; > + bm,pool-short = <3>; > fixed-link { > speed = <1000>; > full-duplex; > @@ -106,6 +110,9 @@ > pinctrl-names = "default"; > status = "okay"; > phy-mode = "rgmii-id"; > + buffer-manager = <&bm>; > + bm,pool-long = <1>; > + bm,pool-short = <3>; Same question that above. Gregory > fixed-link { > speed = <1000>; > full-duplex; > @@ -186,6 +193,10 @@ > }; > }; > > + bm@c8000 { > + status = "okay"; > + }; > + > nand@d0000 { > status = "okay"; > num-cs = <1>; > @@ -259,6 +270,10 @@ > }; > }; > }; > + > + bm-bppi { > + status = "okay"; > + }; > }; > > gpio_keys { > -- > 2.10.2 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com